You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2017/10/02 03:54:12 UTC

[GitHub] spark pull request #19392: [SPARK-22169][SQL] table name with numbers and ch...

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19392#discussion_r142054949
  
    --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
    @@ -510,11 +510,15 @@ rowFormat
         ;
     
     tableIdentifier
    -    : (db=identifier '.')? table=identifier
    +    : (db=identifierPart '.')? table=identifierPart
         ;
     
     functionIdentifier
    -    : (db=identifier '.')? function=identifier
    +    : (db=identifierPart '.')? function=identifierPart
    +    ;
    +
    +identifierPart
    +    : identifier | BIGINT_LITERAL | SMALLINT_LITERAL | TINYINT_LITERAL | BYTELENGTH_LITERAL
    --- End diff --
    
    `INTEGER_VALUE`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org