You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/04/28 01:30:34 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #5717: add license to file header and fix Notice file
yangzhg opened a new pull request #5717:
URL: https://github.com/apache/incubator-doris/pull/5717
## Proposed changes
add license to file header and fix Notice file
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #5717: add license to file header and fix Notice file
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #5717:
URL: https://github.com/apache/incubator-doris/pull/5717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #5717: add license to file header and fix Notice file
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #5717:
URL: https://github.com/apache/incubator-doris/pull/5717#discussion_r621746374
##########
File path: NOTICE.txt
##########
@@ -7,20 +7,59 @@ The Apache Software Foundation (http://www.apache.org/).
Based on source code originally developed by
Baidu (http://www.baidu.com/).
-This product includes software developed by the LevelDB.
-Copyright (c) 2011 The LevelDB Authors. All rights reserved.
+--------------------------------------------------------------------------------
-This product includes software developed by CPython for searching string function.
-(https://github.com/python/cpython)
+This product includes code from Apache commons-lang, which includes the following in
+its NOTICE file:
-This product includes software developed by Chromium.
-Copyright (c) 2011 The Chromium Authors. All rights reserved.
+ Apache commons-lang
+ Copyright 2001-2020 The Apache Software Foundation
-This product includes software developed by Austin Appleby for MurmurHash3.
-The author hereby disclaims copyright to this source code.
+ This product includes software developed at
+ The Apache Software Foundation (http://www.apache.org/).
Review comment:
I think there is no need to put `Apache commons-lang`' NOTICE file here, because it is a Apache software and there is no other special statement in its NOTICE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org