You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2021/11/29 10:03:12 UTC
[skywalking] branch master updated: Remove `logback` dependencies in IoTDB plugin (#8202)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 1acba5d Remove `logback` dependencies in IoTDB plugin (#8202)
1acba5d is described below
commit 1acba5d2467f6d905a6261e999f85464d5432562
Author: mrproliu <74...@qq.com>
AuthorDate: Mon Nov 29 18:02:54 2021 +0800
Remove `logback` dependencies in IoTDB plugin (#8202)
---
CHANGES.md | 1 +
.../server-storage-plugin/storage-iotdb-plugin/pom.xml | 12 ++++++++++++
tools/dependencies/known-oap-backend-dependencies.txt | 2 --
3 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/CHANGES.md b/CHANGES.md
index 102b178..f37d0c7 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -61,6 +61,7 @@ Release Notes.
* Fix TopologyQuery.loadEndpointRelation bug.
* Support using IoTDB as a new storage option.
* Add customized envoy ALS protocol receiver for satellite transmit batch data.
+* Remove `logback` dependencies in IoTDB plugin.
#### UI
diff --git a/oap-server/server-storage-plugin/storage-iotdb-plugin/pom.xml b/oap-server/server-storage-plugin/storage-iotdb-plugin/pom.xml
index e1c6507..857f21b 100644
--- a/oap-server/server-storage-plugin/storage-iotdb-plugin/pom.xml
+++ b/oap-server/server-storage-plugin/storage-iotdb-plugin/pom.xml
@@ -49,6 +49,18 @@
<groupId>net.jpountz.lz4</groupId>
<artifactId>lz4</artifactId>
</exclusion>
+ <!-- When logback + log4j2 + slf4j co-existed in OAP server classpath at the runtime, -->
+ <!-- SkyWalking so11y reported a runtime negative impact about performance. -->
+ <!-- Disable this, and use slf4j-log4j instead of. -->
+ <!-- Ref original discussion, https://github.com/apache/skywalking/pull/8194 -->
+ <exclusion>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-core</artifactId>
+ </exclusion>
</exclusions>
</dependency>
<dependency>
diff --git a/tools/dependencies/known-oap-backend-dependencies.txt b/tools/dependencies/known-oap-backend-dependencies.txt
index 0c1ad0b..f29d69d 100755
--- a/tools/dependencies/known-oap-backend-dependencies.txt
+++ b/tools/dependencies/known-oap-backend-dependencies.txt
@@ -97,8 +97,6 @@ log4j-api-2.14.1.jar
log4j-core-2.14.1.jar
log4j-over-slf4j-1.7.30.jar
log4j-slf4j-impl-2.14.1.jar
-logback-classic-1.2.3.jar
-logback-core-1.2.3.jar
logging-interceptor-3.13.1.jar
lz4-java-1.6.0.jar
micrometer-core-1.7.4.jar