You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/15 16:33:50 UTC
[GitHub] [incubator-doris] acelyc111 opened a new pull request #3326: [LSAN]
Fix some memory leak dectected by LSAN
acelyc111 opened a new pull request #3326: [LSAN] Fix some memory leak dectected by LSAN
URL: https://github.com/apache/incubator-doris/pull/3326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #3326:
[LSAN] Fix some memory leak detected by LSAN
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3326: [LSAN] Fix some memory leak detected by LSAN
URL: https://github.com/apache/incubator-doris/pull/3326#discussion_r409275162
##########
File path: be/src/exec/es/es_query_builder.cpp
##########
@@ -169,20 +170,16 @@ BooleanQueryBuilder::BooleanQueryBuilder() {
}
BooleanQueryBuilder::~BooleanQueryBuilder() {
for (auto clause : _must_clauses) {
- delete clause;
- clause = nullptr;
+ SAFE_DELETE(clause);
Review comment:
just delete is OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #3326:
[LSAN] Fix some memory leak detected by LSAN
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3326: [LSAN] Fix some memory leak detected by LSAN
URL: https://github.com/apache/incubator-doris/pull/3326#discussion_r409274783
##########
File path: be/src/exec/es/es_predicate.cpp
##########
@@ -178,7 +179,7 @@ EsPredicate::EsPredicate(ExprContext* context,
EsPredicate::~EsPredicate() {
for(int i=0; i < _disjuncts.size(); i++) {
- delete _disjuncts[i];
+ SAFE_DELETE(_disjuncts[i]);
Review comment:
It is safe to `delete nullptr`, and `_disjuncts` is cleared later on, so keep using delete is OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 edited a comment on issue #3326: [LSAN]
Fix some memory leak detected by LSAN
Posted by GitBox <gi...@apache.org>.
acelyc111 edited a comment on issue #3326: [LSAN] Fix some memory leak detected by LSAN
URL: https://github.com/apache/incubator-doris/pull/3326#issuecomment-615029457
> Does this CL solve the memory leak problem as you describe in your issue? #3328
I'll report the result after some days‘ observation, maybe the next Monday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #3326: [LSAN] Fix
some memory leak detected by LSAN
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #3326: [LSAN] Fix some memory leak detected by LSAN
URL: https://github.com/apache/incubator-doris/pull/3326#issuecomment-614999580
Does this CL solve the memory leak problem as you describe in your issue? #3328
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #3326: [LSAN] Fix
some memory leak detected by LSAN
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #3326: [LSAN] Fix some memory leak detected by LSAN
URL: https://github.com/apache/incubator-doris/pull/3326#issuecomment-614377096
Could you make an ISSUE to describe the bug you try to fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on issue #3326: [LSAN] Fix
some memory leak detected by LSAN
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on issue #3326: [LSAN] Fix some memory leak detected by LSAN
URL: https://github.com/apache/incubator-doris/pull/3326#issuecomment-615029457
> Does this CL solve the memory leak problem as you describe in your issue? #3328
I'll report the result after some days‘ observation, may the next Monday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on issue #3326: [LSAN] Fix
some memory leak detected by LSAN
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on issue #3326: [LSAN] Fix some memory leak detected by LSAN
URL: https://github.com/apache/incubator-doris/pull/3326#issuecomment-614420904
> Could you make an ISSUE to describe the bug you try to fix?
Added it, https://github.com/apache/incubator-doris/issues/3328
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org