You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Alanxtl (via GitHub)" <gi...@apache.org> on 2025/05/26 09:05:11 UTC
[PR] feat: Update nacos-farconf sample [dubbo-go-pixiu-samples]
Alanxtl opened a new pull request, #76:
URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/76
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
- rename farconfnacos to nacos-farconf
- update the readme.md of nacos-farconf, add readme_zh.md of nacos-farconf
- delete useless `server` folder in nacos-farconf, remove its conter part in readme.md
- update the nacos version in this sample
- fix the typo in `dubbogo/simple/nacos_farconf/pixiu/conf.yaml`, previous version cannot be run successfully without this revision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: Update nacos-farconf sample [dubbo-go-pixiu-samples]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #76:
URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/76#discussion_r2108172836
##########
README.md:
##########
@@ -13,7 +13,7 @@ samples for [dubbo-go-pixiu](https://github.com/apache/dubbo-go-pixiu)
- dubbogo/simple/body: http to dubbo with api_config.yaml
- dubbogo/simple/csrf: csrf protection
- dubbogo/simple/direct: http to dubbo with direct generic call
- - dubbogo/simple/farconfnacos: pixiu with nacos remote Configuration Center
+ - dubbogo/simple/nacos_farconf: pixiu use nacos as remote config center
Review Comment:
pixiu uses nacos as a remote config center
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: Update nacos-farconf sample [dubbo-go-pixiu-samples]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks merged PR #76:
URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: Update nacos-farconf sample [dubbo-go-pixiu-samples]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on code in PR #76:
URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/76#discussion_r2111150902
##########
dubbogo/simple/nacos_farconf/nacos/nacos.yaml:
##########
@@ -26,35 +26,35 @@ static_resources:
address: "0.0.0.0"
port: 8881
filter_chains:
- filters:
- - name: dgp.filter.httpconnectionmanager
- config:
- route_config:
- routes:
- - match:
- prefix: "*"
- http_filters:
- - name: dgp.filter.http.dubboproxy
- config:
- dubboProxyConfig:
- auto_resolve: true
- registries:
- "zookeeper":
- protocol: "zookeeper"
- timeout: "3s"
- address: "127.0.0.1:2181"
- username: ""
- password: ""
- timeout_config:
- connect_timeout: 5s
- request_timeout: 5s
+ filters:
+ - name: dgp.filter.httpconnectionmanager
+ config:
+ route_config:
+ routes:
+ - match:
+ prefix: "*"
+ http_filters:
+ - name: dgp.filter.http.dubboproxy
+ config:
+ dubboProxyConfig:
+ auto_resolve: true
+ registries:
+ "zookeeper":
+ protocol: "zookeeper"
+ timeout: "3s"
+ address: "127.0.0.1:2181"
+ username: ""
+ password: ""
+ timeout_config:
+ connect_timeout: 5s
+ request_timeout: 5s
- server_name: "test_http_dubbo"
- generate_request_id: false
+ server_name: "test_http_dubbo"
+ generate_request_id: false
config:
- idle_timeout: 5s
- read_timeout: 5s
- write_timeout: 5s
+ idle_timeout: 123s
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: Update nacos-farconf sample [dubbo-go-pixiu-samples]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #76:
URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/76#discussion_r2173633311
##########
dubbogo/simple/nacos_farconf/docker/docker-compose.yml:
##########
@@ -20,18 +20,17 @@
version: '3'
services:
- zookeeper:
- image: zookeeper
- ports:
- - 2181:2181
- restart: on-failure
nacos:
- image: nacos/nacos-server:2.0.1
+ image: nacos/nacos-server:v2.5.1
container_name: nacos-standalone
environment:
- PREFER_HOST_MODE=hostname
- MODE=standalone
+# - NACOS_AUTH_ENABLE=false
- NACOS_AUTH_ENABLE=true
+ - NACOS_AUTH_TOKEN=DboQPxIongllAOHCyap9JiuJQ0sqHgh+31QQe4+17cM=
Review Comment:
Hard-coded authentication token in source; consider sourcing secrets from environment variables or a secure vault to avoid committing sensitive credentials.
```suggestion
- NACOS_AUTH_TOKEN=${NACOS_AUTH_TOKEN}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: Update nacos-farconf sample [dubbo-go-pixiu-samples]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #76:
URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/76#discussion_r2109531491
##########
dubbogo/simple/nacos_farconf/nacos/nacos.yaml:
##########
@@ -26,35 +26,35 @@ static_resources:
address: "0.0.0.0"
port: 8881
filter_chains:
- filters:
- - name: dgp.filter.httpconnectionmanager
- config:
- route_config:
- routes:
- - match:
- prefix: "*"
- http_filters:
- - name: dgp.filter.http.dubboproxy
- config:
- dubboProxyConfig:
- auto_resolve: true
- registries:
- "zookeeper":
- protocol: "zookeeper"
- timeout: "3s"
- address: "127.0.0.1:2181"
- username: ""
- password: ""
- timeout_config:
- connect_timeout: 5s
- request_timeout: 5s
+ filters:
+ - name: dgp.filter.httpconnectionmanager
+ config:
+ route_config:
+ routes:
+ - match:
+ prefix: "*"
+ http_filters:
+ - name: dgp.filter.http.dubboproxy
+ config:
+ dubboProxyConfig:
+ auto_resolve: true
+ registries:
+ "zookeeper":
+ protocol: "zookeeper"
+ timeout: "3s"
+ address: "127.0.0.1:2181"
+ username: ""
+ password: ""
+ timeout_config:
+ connect_timeout: 5s
+ request_timeout: 5s
- server_name: "test_http_dubbo"
- generate_request_id: false
+ server_name: "test_http_dubbo"
+ generate_request_id: false
config:
- idle_timeout: 5s
- read_timeout: 5s
- write_timeout: 5s
+ idle_timeout: 123s
Review Comment:
为何把时长拉这么长?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: Update nacos-farconf sample [dubbo-go-pixiu-samples]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on code in PR #76:
URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/76#discussion_r2108317656
##########
README.md:
##########
@@ -13,7 +13,7 @@ samples for [dubbo-go-pixiu](https://github.com/apache/dubbo-go-pixiu)
- dubbogo/simple/body: http to dubbo with api_config.yaml
- dubbogo/simple/csrf: csrf protection
- dubbogo/simple/direct: http to dubbo with direct generic call
- - dubbogo/simple/farconfnacos: pixiu with nacos remote Configuration Center
+ - dubbogo/simple/nacos_farconf: pixiu use nacos as remote config center
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org