You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Li Pi (JIRA)" <ji...@apache.org> on 2011/09/26 00:47:26 UTC
[jira] [Created] (HBASE-4482) Race Condition Concerning Eviction in
SlabCache
Race Condition Concerning Eviction in SlabCache
-----------------------------------------------
Key: HBASE-4482
URL: https://issues.apache.org/jira/browse/HBASE-4482
Project: HBase
Issue Type: Sub-task
Reporter: Li Pi
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121710#comment-13121710 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/
-----------------------------------------------------------
(Updated 2011-10-06 04:20:33.696931)
Review request for hbase.
Changes
-------
v4 of the diff. Got rid of the whole putIfAbsent/onEviction loops. Replaced with synchronize and thread.sleep/wait.
Summary
-------
Bugfix, kills a race condition.
Ignore r1, thats the wrong patch.
This addresses bug HBASE-4482.
https://issues.apache.org/jira/browse/HBASE-4482
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 4072387
src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
Diff: https://reviews.apache.org/r/2051/diff
Testing
-------
Looped tests.
Thanks,
Li
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4482) Race Condition Concerning Eviction in
SlabCache
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4482:
-------------------------
Priority: Blocker (was: Critical)
Making this a blocker because its a blocker on a blocker.
I suppose we can back out this feature if not done by the time we cut a 0.92.... shouldn't hold up the release (I suppose that makes it not a blocker)
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121740#comment-13121740 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/
-----------------------------------------------------------
(Updated 2011-10-06 05:46:49.397731)
Review request for hbase.
Changes
-------
fixed as per ted yu's request.
Summary
-------
Bugfix, kills a race condition.
Ignore r1, thats the wrong patch.
This addresses bug HBASE-4482.
https://issues.apache.org/jira/browse/HBASE-4482
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 4072387
src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
Diff: https://reviews.apache.org/r/2051/diff
Testing
-------
Looped tests.
Thanks,
Li
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114885#comment-13114885 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Bugfix, kills a race condition.
This addresses bug HBASE-4482.
https://issues.apache.org/jira/browse/HBASE-4482
Diffs
-----
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java fe25a45
Diff: https://reviews.apache.org/r/2051/diff
Testing
-------
Looped tests.
Thanks,
Li
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114843#comment-13114843 ]
Li Pi commented on HBASE-4482:
------------------------------
Nevermind - this is still broken. Gotta fix something else.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4482) Race Condition Concerning Eviction in
SlabCache
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4482:
-------------------------
Attachment: hbase-4482v4.2.txt
Here is what I applied copied from RB.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt, hbase-4482v4.2.txt, hbase-4482v4.2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114883#comment-13114883 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/
-----------------------------------------------------------
(Updated 2011-09-26 19:17:34.041967)
Review request for hbase.
Summary (updated)
-------
Bugfix, kills a race condition.
Ignore r1, thats the wrong patch.
This addresses bug HBASE-4482.
https://issues.apache.org/jira/browse/HBASE-4482
Diffs
-----
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0c06f4f
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java fd9e7ef
src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
Diff: https://reviews.apache.org/r/2051/diff
Testing
-------
Looped tests.
Thanks,
Li
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121731#comment-13121731 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/#review2384
-----------------------------------------------------------
After looping TestSlabCache 50 times and TestSingleSizeCache 30 times, I didn't see test failure.
There is one bug, see below.
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
<https://reviews.apache.org/r/2051/#comment5480>
Indent to the right two spaces.
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
<https://reviews.apache.org/r/2051/#comment5482>
Should be (offHeapCacheSize <= 0 || !enableOffHeapCache)
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
<https://reviews.apache.org/r/2051/#comment5481>
Whitespace.
- Ted
On 2011-10-06 04:25:43, Li Pi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2051/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-06 04:25:43)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Bugfix, kills a race condition.
bq.
bq. Ignore r1, thats the wrong patch.
bq.
bq.
bq. This addresses bug HBASE-4482.
bq. https://issues.apache.org/jira/browse/HBASE-4482
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 4072387
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
bq.
bq. Diff: https://reviews.apache.org/r/2051/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Looped tests.
bq.
bq.
bq. Thanks,
bq.
bq. Li
bq.
bq.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-4482) Race Condition
Concerning Eviction in SlabCache
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114824#comment-13114824 ]
Ted Yu edited comment on HBASE-4482 at 9/26/11 5:38 PM:
--------------------------------------------------------
Ran tests overnight, no looping detected. Put
{noformat}
while (backingStore.putIfAbsent(blockName, scache) != null) {
int i = 0;
Thread.yield();
i++;
if (i > 1000){
System.out.println("TEST FAILING AT REMOVE");
}
}
{noformat}
in the two while loops.
Will put out patch v3 in a moment.
was (Author: li):
Ran tests overnight, no looping detected. Put while (backingStore.putIfAbsent(blockName, scache) != null) {
int i = 0;
Thread.yield();
i++;
if (i > 1000){
System.out.println("TEST FAILING AT REMOVE");
}
}
in the two while loops.
Will put out patch v3 in a moment.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114887#comment-13114887 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/
-----------------------------------------------------------
(Updated 2011-09-26 19:16:53.815702)
Review request for hbase.
Changes
-------
patch v3 - ted yu wanted to compare between the two.
Summary
-------
Bugfix, kills a race condition.
This addresses bug HBASE-4482.
https://issues.apache.org/jira/browse/HBASE-4482
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0c06f4f
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java fd9e7ef
src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
Diff: https://reviews.apache.org/r/2051/diff
Testing
-------
Looped tests.
Thanks,
Li
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "Jonathan Gray (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122034#comment-13122034 ]
Jonathan Gray commented on HBASE-4482:
--------------------------------------
+1 on keeping this in 0.92 regardless of stability and marking as experimental.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt, hbase-4482v4.2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121735#comment-13121735 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
bq. On 2011-10-06 05:30:17, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java, line 397
bq. > <https://reviews.apache.org/r/2051/diff/5/?file=48444#file48444line397>
bq. >
bq. > Should be (offHeapCacheSize <= 0 || !enableOffHeapCache)
Fixed.
bq. On 2011-10-06 05:30:17, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java, line 401
bq. > <https://reviews.apache.org/r/2051/diff/5/?file=48444#file48444line401>
bq. >
bq. > Whitespace.
Fixed.
bq. On 2011-10-06 05:30:17, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java, line 225
bq. > <https://reviews.apache.org/r/2051/diff/5/?file=48442#file48442line225>
bq. >
bq. > Indent to the right two spaces.
Fixed.
- Li
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/#review2384
-----------------------------------------------------------
On 2011-10-06 04:25:43, Li Pi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2051/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-06 04:25:43)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Bugfix, kills a race condition.
bq.
bq. Ignore r1, thats the wrong patch.
bq.
bq.
bq. This addresses bug HBASE-4482.
bq. https://issues.apache.org/jira/browse/HBASE-4482
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 4072387
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
bq.
bq. Diff: https://reviews.apache.org/r/2051/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Looped tests.
bq.
bq.
bq. Thanks,
bq.
bq. Li
bq.
bq.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4482) Race Condition Concerning Eviction in
SlabCache
Posted by "Li Pi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4482:
-------------------------
Attachment: hbase-4482v4.2.txt
final version.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt, hbase-4482v4.2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4482) Race Condition Concerning Eviction in
SlabCache
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4482:
-------------------------
Attachment: hbase-4482v2.txt
rebased and tests reenabled.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119553#comment-13119553 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/#review2283
-----------------------------------------------------------
This looks good but for the issues the boys raised above. You going to fix Li or should I try and fix on commit?
- Michael
On 2011-09-26 19:17:34, Li Pi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2051/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-26 19:17:34)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Bugfix, kills a race condition.
bq.
bq. Ignore r1, thats the wrong patch.
bq.
bq.
bq. This addresses bug HBASE-4482.
bq. https://issues.apache.org/jira/browse/HBASE-4482
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0c06f4f
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java fd9e7ef
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
bq.
bq. Diff: https://reviews.apache.org/r/2051/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Looped tests.
bq.
bq.
bq. Thanks,
bq.
bq. Li
bq.
bq.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4482) Race Condition Concerning Eviction in
SlabCache
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4482:
-------------------------
Status: Patch Available (was: Open)
Fixes this. Will begin looping tests to see if it hangs.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120566#comment-13120566 ]
stack commented on HBASE-4482:
------------------------------
bq. The new cache is already marked experimental, right? If so, I don't think we have to necessarily back it out - just so long as people are clear that when they enable it they're playing with some fire
Makes sense.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120558#comment-13120558 ]
Todd Lipcon commented on HBASE-4482:
------------------------------------
The new cache is already marked experimental, right? If so, I don't think we have to necessarily back it out - just so long as people are clear that when they enable it they're playing with some fire :)
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4482) Race Condition Concerning Eviction in
SlabCache
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4482:
-------------------------
Priority: Critical (was: Major)
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121155#comment-13121155 ]
Li Pi commented on HBASE-4482:
------------------------------
The interesting bit: http://pastebin.com/Xj6bdFMs
The same thread is calling both putIfAbsent and the remove loops. Assuming I am reading this stacktrace right.
The loops are supposed to block eachother. I'm confused for now.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4482) Race Condition Concerning Eviction in
SlabCache
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4482:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to 0.92 branch and trunk because of Ted and Jon +1s. Thanks for the patch Li Pi.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt, hbase-4482v4.2.txt, hbase-4482v4.2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121713#comment-13121713 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/
-----------------------------------------------------------
(Updated 2011-10-06 04:25:43.653003)
Review request for hbase.
Changes
-------
Addressed JGray's reviews above.
Testing reveals this one not to fail (yet).
Summary
-------
Bugfix, kills a race condition.
Ignore r1, thats the wrong patch.
This addresses bug HBASE-4482.
https://issues.apache.org/jira/browse/HBASE-4482
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 4072387
src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
Diff: https://reviews.apache.org/r/2051/diff
Testing
-------
Looped tests.
Thanks,
Li
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114888#comment-13114888 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/#review2071
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
<https://reviews.apache.org/r/2051/#comment4667>
Can you comment here on the change? And should this use LOG instead of System.out?
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
<https://reviews.apache.org/r/2051/#comment4668>
add a reference to the JIRA # in this comment... and break this to two lines.
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java
<https://reviews.apache.org/r/2051/#comment4669>
remove from javadoc
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/2051/#comment4670>
Do we need this? At the least should be a DEBUG (seems like RS logs will be filled with this though, is that intended?)
- Jonathan
On 2011-09-26 19:17:34, Li Pi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2051/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-26 19:17:34)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Bugfix, kills a race condition.
bq.
bq. Ignore r1, thats the wrong patch.
bq.
bq.
bq. This addresses bug HBASE-4482.
bq. https://issues.apache.org/jira/browse/HBASE-4482
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0c06f4f
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java fd9e7ef
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
bq.
bq. Diff: https://reviews.apache.org/r/2051/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Looped tests.
bq.
bq.
bq. Thanks,
bq.
bq. Li
bq.
bq.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121712#comment-13121712 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
bq. On 2011-09-26 19:52:28, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java, line 221
bq. > <https://reviews.apache.org/r/2051/diff/2-3/?file=45773#file45773line221>
bq. >
bq. > This log would be expensive.
Got rid of that.
- Li
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/#review2070
-----------------------------------------------------------
On 2011-10-06 04:20:33, Li Pi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2051/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-06 04:20:33)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Bugfix, kills a race condition.
bq.
bq. Ignore r1, thats the wrong patch.
bq.
bq.
bq. This addresses bug HBASE-4482.
bq. https://issues.apache.org/jira/browse/HBASE-4482
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 4072387
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
bq.
bq. Diff: https://reviews.apache.org/r/2051/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Looped tests.
bq.
bq.
bq. Thanks,
bq.
bq. Li
bq.
bq.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi reassigned HBASE-4482:
----------------------------
Assignee: Li Pi
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Fix For: 0.92.0
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119615#comment-13119615 ]
Li Pi commented on HBASE-4482:
------------------------------
Uh - thats not quite fixed yet, theres another race condition this
patch causes, after getting rid of one
Somehow, somewhere, the cache invariant is getting broken. Eventually
I'll figure out why.
On Mon, Oct 3, 2011 at 1:00 PM, jiraposter@reviews.apache.org
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "Li Pi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121147#comment-13121147 ]
Li Pi commented on HBASE-4482:
------------------------------
After applying patch v2. Current status is, It is very difficult to reproduce the bug. Ted Yu has a stacktrace.
The interested bit I posted to http://pastebin.com/Xj6bdFMs.
The SlabCache maintains an invariant: that SlabCache and SingleSlabCache, will, in steady state, either both have an entry or neither of them have an entry.
In order to maintain this invariant, SlabCache does a few things.
For any given caching operation, SlabCache will write to its backingStore EXACTLY once. If an entry already exists.
This is why theres this loop here:
while (backingStore.putIfAbsent(blockName, scache) != null); (I should put a thread.yield() in here).
SlabCache cannot remove an entry from its backingStore unless a SingleSizeCache calls its onEviction. SingleSizeCache will only call onEviction once and only once for any given key. This is enforced with a synchronize block.
Once onEviction is called, SlabCache will remove one, and EXACTLY one entry. It will loop until it does this.
while ((backingStore.remove(key)) == null) {
Thread.yield();
}
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114381#comment-13114381 ]
Li Pi commented on HBASE-4482:
------------------------------
Problem:
Steady State: SingleSizeCache and SlabCache both contain key "A"
Thread A: Caches something, starting eviction of Key A.
Thread B: Checks for Key A -> Returns Gets Null, as eviction has begun
Thread B: Recaches Key A, gets to SingleSizeCache, does not get the
PutIfAbsentLoop yet...
Thread C: Caches another key, starting the second eviction of Key A.
Thread A: does its onEviction, removing the entry of Key A from SlabCache.
Thread C: does its onEviction, removing the (blank) entry of Key A
from SlabCache:
Thread B: goes to putifabsent, and puts its entry into SlabCache
end result:
Key A in SlabCache, but not in SingleSizeCache.
When Key A is recached, it will stall at putifAbsent forever.
This causes the test to hang, and build to not pass.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Fix For: 0.92.0
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4482) Race Condition Concerning Eviction in
SlabCache
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4482:
-------------------------
Attachment: hbase-4482v1.txt
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114884#comment-13114884 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/
-----------------------------------------------------------
(Updated 2011-09-26 19:16:31.129009)
Review request for hbase.
Changes
-------
patch v2.
Summary
-------
Bugfix, kills a race condition.
This addresses bug HBASE-4482.
https://issues.apache.org/jira/browse/HBASE-4482
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0c06f4f
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java fd9e7ef
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
Diff: https://reviews.apache.org/r/2051/diff
Testing
-------
Looped tests.
Thanks,
Li
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121711#comment-13121711 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
bq. On 2011-09-26 20:01:05, Jonathan Gray wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java, line 222
bq. > <https://reviews.apache.org/r/2051/diff/3/?file=45780#file45780line222>
bq. >
bq. > Can you comment here on the change? And should this use LOG instead of System.out?
Removed this part entirely.
bq. On 2011-09-26 20:01:05, Jonathan Gray wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java, line 312
bq. > <https://reviews.apache.org/r/2051/diff/3/?file=45780#file45780line312>
bq. >
bq. > add a reference to the JIRA # in this comment... and break this to two lines.
Will do.
bq. On 2011-09-26 20:01:05, Jonathan Gray wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java, lines 33-34
bq. > <https://reviews.apache.org/r/2051/diff/3/?file=45781#file45781line33>
bq. >
bq. > remove from javadoc
Will do.
bq. On 2011-09-26 20:01:05, Jonathan Gray wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java, line 1272
bq. > <https://reviews.apache.org/r/2051/diff/3/?file=45782#file45782line1272>
bq. >
bq. > Do we need this? At the least should be a DEBUG (seems like RS logs will be filled with this though, is that intended?)
Will remove.
- Li
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/#review2071
-----------------------------------------------------------
On 2011-10-06 04:20:33, Li Pi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2051/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-06 04:20:33)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Bugfix, kills a race condition.
bq.
bq. Ignore r1, thats the wrong patch.
bq.
bq.
bq. This addresses bug HBASE-4482.
bq. https://issues.apache.org/jira/browse/HBASE-4482
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 3840279
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 4072387
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
bq.
bq. Diff: https://reviews.apache.org/r/2051/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Looped tests.
bq.
bq.
bq. Thanks,
bq.
bq. Li
bq.
bq.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121743#comment-13121743 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/#review2386
-----------------------------------------------------------
Ship it!
- Ted
On 2011-10-06 05:46:49, Li Pi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2051/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-06 05:46:49)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Bugfix, kills a race condition.
bq.
bq. Ignore r1, thats the wrong patch.
bq.
bq.
bq. This addresses bug HBASE-4482.
bq. https://issues.apache.org/jira/browse/HBASE-4482
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 4072387
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
bq.
bq. Diff: https://reviews.apache.org/r/2051/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Looped tests.
bq.
bq.
bq. Thanks,
bq.
bq. Li
bq.
bq.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114824#comment-13114824 ]
Li Pi commented on HBASE-4482:
------------------------------
Ran tests overnight, no looping detected. Put while (backingStore.putIfAbsent(blockName, scache) != null) {
int i = 0;
Thread.yield();
i++;
if (i > 1000){
System.out.println("TEST FAILING AT REMOVE");
}
}
in the two while loops.
Will put out patch v3 in a moment.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119650#comment-13119650 ]
Ted Yu commented on HBASE-4482:
-------------------------------
+1 on this simplification.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119649#comment-13119649 ]
Todd Lipcon commented on HBASE-4482:
------------------------------------
I was thinking about this a bit over the weekend. Though the current composition of SingleSizeCaches into SlabCache is pretty, it's causing a lot of these bugs regarding coordination between the two.
I'd like to consider a simplification here - what if we got rid of SingleSizeCache, and manually kept the LRU lists per size? Basically, dial back the concurrency a bit in favor of a simpler design, then if we see bottlenecks or lock contention, we can address it.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114880#comment-13114880 ]
jiraposter@reviews.apache.org commented on HBASE-4482:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2051/#review2070
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
<https://reviews.apache.org/r/2051/#comment4666>
This log would be expensive.
- Ted
On 2011-09-26 19:17:34, Li Pi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2051/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-26 19:17:34)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Bugfix, kills a race condition.
bq.
bq. Ignore r1, thats the wrong patch.
bq.
bq.
bq. This addresses bug HBASE-4482.
bq. https://issues.apache.org/jira/browse/HBASE-4482
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0c06f4f
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java fd9e7ef
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159
bq.
bq. Diff: https://reviews.apache.org/r/2051/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Looped tests.
bq.
bq.
bq. Thanks,
bq.
bq. Li
bq.
bq.
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4482) Race Condition Concerning Eviction
in SlabCache
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122447#comment-13122447 ]
Hudson commented on HBASE-4482:
-------------------------------
Integrated in HBase-0.92 #49 (See [https://builds.apache.org/job/HBase-0.92/49/])
HBASE-4482 Race Condition Concerning Eviction in SlabCache
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java
> Race Condition Concerning Eviction in SlabCache
> -----------------------------------------------
>
> Key: HBASE-4482
> URL: https://issues.apache.org/jira/browse/HBASE-4482
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: hbase-4482v1.txt, hbase-4482v2.txt, hbase-4482v4.2.txt, hbase-4482v4.2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira