You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "ArnavBalyan (via GitHub)" <gi...@apache.org> on 2026/05/12 05:13:03 UTC

[PR] [hive] Fix insert into static partitions on managed Paimon tables [paimon]

ArnavBalyan opened a new pull request, #7824:
URL: https://github.com/apache/paimon/pull/7824

   ### Purpose
    - Insert into static partition against a Hive managed table fails with `ArrayIndexOutOfBoundsException` in `TableWriteImpl.checkNullability`. 
    - This is because Hive sends data rows without the static partition columns and instead passes their values in `path`/`partition_columns` serde property.
    - PaimonOutputFormat.getHiveRecordWriter does not respect these properties, and row arrives incomplete.
    -  Read the partition column names, parse the values and wrap the writer which is aware of the extra properies and can construct the row properly. 
    - Closes user reported bug #7064.
   ### Tests
    - UT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hive] Fix insert into static partitions on managed Paimon tables [paimon]

Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #7824:
URL: https://github.com/apache/paimon/pull/7824#issuecomment-4612924912

   Hi @leaves12138 thanks for the re-review, have addressed both comments and the CI is now green. Could you please take a look again thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hive] Fix insert into static partitions on managed Paimon tables [paimon]

Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #7824:
URL: https://github.com/apache/paimon/pull/7824#issuecomment-4430913246

   cc @leaves12138 @JingsongLi thanks! :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hive] Fix insert into static partitions on managed Paimon tables [paimon]

Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #7824:
URL: https://github.com/apache/paimon/pull/7824#issuecomment-4466837955

   cc @JingsongLi gentle reminder if you could PTAL thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hive] Fix insert into static partitions on managed Paimon tables [paimon]

Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #7824:
URL: https://github.com/apache/paimon/pull/7824#issuecomment-4526922733

   Thanks for the review! Have addressed all comments
   
     **1. Partition column ordering assumption**
     Added a check that throws a clear error when partition columns aren't the trailing columns of the schema. Covered by a new unit test.
   
     **2. Mixed static/dynamic partitions**
     Documented why we fall back to the unwrapped writer when a partition key has no value in the path, and flags this as a known unsupported case.
   
     **3. Separator in the partition columns property**
     Extracted the forward slash into a constant with a comment explaining it's the Hive metastore convention, not the OS path separator.
   
     **4. Direct access to the underlying batch write**
     Added a write method on the inner writer. Both the wrapped and unwrapped paths now go through this, so any future logic added to the write path won't be silently bypassed.
   
     **5. Inconsistent exception wrapping**
     Aligned both write paths to throw the same exception type, so error handling upstream is consistent.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hive] Fix insert into static partitions on managed Paimon tables [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #7824:
URL: https://github.com/apache/paimon/pull/7824


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hive] Fix insert into static partitions on managed Paimon tables [paimon]

Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #7824:
URL: https://github.com/apache/paimon/pull/7824#issuecomment-4427528702

   cc @JingsongLi thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [hive] Fix insert into static partitions on managed Paimon tables [paimon]

Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #7824:
URL: https://github.com/apache/paimon/pull/7824#issuecomment-4516129787

   cc @leaves12138 @JingsongLi gentle reminder thanks ! :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org