[GitHub] [lucene] mikemccand commented on a change in pull request #751: LUCENE-10467: Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0

[GitBox <gi...@apache.org>]

mikemccand commented on a change in pull request #751:
URL: https://github.com/apache/lucene/pull/751#discussion_r830102401



##########
File path: lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
##########
@@ -348,6 +348,9 @@ private void increment(long value) {
 
   @Override
   public FacetResult getTopChildren(int topN, String dim, String... path) {
+    if (topN <= 0) {

Review comment:
       Could we maybe factor out a `static` package-private helper method `validateTopN` that would do this check and throw the exception, and call that from all these places?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org