You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2014/11/14 18:09:08 UTC
Review Request 28042: [FALCON-895] Fix intermittent failures in
ProcessInstanceStatus and Kills test classes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28042/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-895
https://issues.apache.org/jira/browse/FALCON-895
Repository: falcon-git
Description
-------
Changes to make tests more stable.
Few comments:
ProcessInstance.testProcessInstanceKillKillNonMaterialized changed to testProcessInstanceKillKillNotRunning because as defined, only RUNNING instances can be killed. Also the argument is that non-materialized states, like READY, SUBMITTED are generally considered the same as WAITING during instance-oriented requests.
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 6c92711
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 7b3fb62
Diff: https://reviews.apache.org/r/28042/diff/
Testing
-------
Tested.
Thanks,
Paul Isaychuk
Re: Review Request 28042: [FALCON-895] Fix intermittent failures in
ProcessInstanceStatus and Kills test classes.
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28042/#review61485
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On Nov. 14, 2014, 9:09 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28042/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 9:09 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-895
> https://issues.apache.org/jira/browse/FALCON-895
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Changes to make tests more stable.
> Few comments:
> ProcessInstance.testProcessInstanceKillKillNonMaterialized changed to testProcessInstanceKillKillNotRunning because as defined, only RUNNING instances can be killed. Also the argument is that non-materialized states, like READY, SUBMITTED are generally considered the same as WAITING during instance-oriented requests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 6c92711
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 7b3fb62
>
> Diff: https://reviews.apache.org/r/28042/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> Paul Isaychuk
>
>