You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stanbol.apache.org by og...@apache.org on 2011/02/09 20:06:59 UTC
svn commit: r1069033 -
/incubator/stanbol/trunk/commons/testing/jarexec/pom.xml
Author: ogrisel
Date: Wed Feb 9 19:06:59 2011
New Revision: 1069033
URL: http://svn.apache.org/viewvc?rev=1069033&view=rev
Log:
switch to java 1.6 for stanbol/commons/testing/jarexec
Modified:
incubator/stanbol/trunk/commons/testing/jarexec/pom.xml
Modified: incubator/stanbol/trunk/commons/testing/jarexec/pom.xml
URL: http://svn.apache.org/viewvc/incubator/stanbol/trunk/commons/testing/jarexec/pom.xml?rev=1069033&r1=1069032&r2=1069033&view=diff
==============================================================================
--- incubator/stanbol/trunk/commons/testing/jarexec/pom.xml (original)
+++ incubator/stanbol/trunk/commons/testing/jarexec/pom.xml Wed Feb 9 19:06:59 2011
@@ -38,8 +38,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>2.3.1</version>
<configuration>
- <source>1.5</source>
- <target>1.5</target>
+ <source>1.6</source>
+ <target>1.6</target>
</configuration>
</plugin>
</plugins>
Re: svn commit: r1069033 - /incubator/stanbol/trunk/commons/testing/jarexec/pom.xml
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Thu, Feb 10, 2011 at 10:45 AM, Olivier Grisel
<ol...@ensta.org> wrote:
> ...are we sure
> we want to have pieces of the stanbol source tree to target different
> VM major versions? It makes stuff more complicated for little added
> benefits IMHO. Unless someone knows of a project that might want to
> re-use jarexec and targets 1.5....
Ok I agree, let's cross that bridge if/when we actually need it.
-Bertrand
Re: svn commit: r1069033 - /incubator/stanbol/trunk/commons/testing/jarexec/pom.xml
Posted by Olivier Grisel <ol...@ensta.org>.
2011/2/10 Fabian Christ <ch...@googlemail.com>:
> Hi,
>
> I have not checked in detail but I think that the commons uses the
> @Override annotation for interfaces which is a 1.6 feature. I think by
> removing such annotations and we can got with 1.5.
Yes I was trying to clean all eclipse visible build warnings.
I don't mind removing the @Override markers instead, but are we sure
we want to have pieces of the stanbol source tree to target different
VM major versions? It makes stuff more complicated for little added
benefits IMHO. Unless someone knows of a project that might want to
re-use jarexec and targets 1.5.
--
Olivier
http://twitter.com/ogrisel - http://github.com/ogrisel
Re: svn commit: r1069033 - /incubator/stanbol/trunk/commons/testing/jarexec/pom.xml
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Thu, Feb 10, 2011 at 10:38 AM, Fabian Christ
<ch...@googlemail.com> wrote:
> ...I have not checked in detail but I think that the commons uses the
> @Override annotation for interfaces which is a 1.6 feature. I think by
> removing such annotations and we can got with 1.5....
Don't think so - commons/jarexec compiles just fine for me after
reverting revision 1069033 (I didn't not revert in svn though, waiting
for Olivier's answer).
-Bertrand
Re: svn commit: r1069033 - /incubator/stanbol/trunk/commons/testing/jarexec/pom.xml
Posted by Fabian Christ <ch...@googlemail.com>.
Hi,
I have not checked in detail but I think that the commons uses the
@Override annotation for interfaces which is a 1.6 feature. I think by
removing such annotations and we can got with 1.5.
- Fabian
2011/2/10 Bertrand Delacretaz <bd...@apache.org>:
> On Wed, Feb 9, 2011 at 8:06 PM, <og...@apache.org> wrote:
>> Author: ogrisel
>> New Revision: 1069033
>> URL: http://svn.apache.org/viewvc?rev=1069033&view=rev
>> Log:
>> switch to java 1.6 for stanbol/commons/testing/jarexec
>>...
>
> Why? This module can be reused outside of stanbol, so I think we
> should use the lowest java version that works.
>
> Mixing it with 1.6-compiled modules is not a problem.
>
> -Bertrand
>
--
Fabian
Re: svn commit: r1069033 - /incubator/stanbol/trunk/commons/testing/jarexec/pom.xml
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, Feb 9, 2011 at 8:06 PM, <og...@apache.org> wrote:
> Author: ogrisel
> New Revision: 1069033
> URL: http://svn.apache.org/viewvc?rev=1069033&view=rev
> Log:
> switch to java 1.6 for stanbol/commons/testing/jarexec
>...
Why? This module can be reused outside of stanbol, so I think we
should use the lowest java version that works.
Mixing it with 1.6-compiled modules is not a problem.
-Bertrand