You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jihoonson <gi...@git.apache.org> on 2015/05/15 16:03:03 UTC

[GitHub] tajo pull request: TAJO-1577: Add test cases to verify join plans

GitHub user jihoonson opened a pull request:

    https://github.com/apache/tajo/pull/571

    TAJO-1577: Add test cases to verify join plans

    This patch is based on @navis's first work (#558).
    Here are the summary of changes.
    * Most join query tests are executed with the ```SimpleTest``` annotation. It includes tests of logical plan, global plan, and query execution result.
    * Join tests are categorized into 6 groups, i.e., TestInnerJoinQuery, TestInnerJoinWithSubQuery, TestOuterJoinQuery, TestOuterJoinWithSubQuery, TestMultipleJoinTypes, and TestJoinOnPartitionedTables.
     * I've newly added the ```NamedTest``` annotation to reuse files for datasets and queries.
     * Some temporal tables are shared across different join tests.
     * Every join test is executed with hash join, sort-merge join, hash-broadcast join, and sort-merge-broadcast join.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jihoonson/tajo-2 TAJO-1577_2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/571.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #571
    
----
commit d15a5138e79450a777fce07ccec5dd34700528e5
Author: navis.ryu <na...@apache.org>
Date:   2015-04-29T04:33:03Z

    TAJO-1577 Add test cases to verify join plans

commit bc8a28dfaddf81e031fa758d7401bfd953240e84
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-12T05:49:19Z

    Merge branch 'TAJO-1577' of https://github.com/navis/tajo into TAJO-1577

commit e86c47668d353554befab603ea32dcd48fb69d03
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-12T07:16:33Z

    TAJO-1577

commit a9686886e3a34763b567f56d214d3239987545f5
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-12T07:43:55Z

    TAJO-1577

commit 96e0c89874c98340d9efb21107e67eef6db4bd74
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-12T08:13:18Z

    Apply simple test for every test in TestJoinQuery

commit 51cecede50bb7c11cff7a5a289787bd346e5729f
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-12T08:28:55Z

    Fix a bug of join qual is not deterministic

commit c9e8abfab46a9586600b0501ead78ce78859a51e
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-12T15:05:36Z

    TAJO-1577_2

commit a4cc6a067cb5d1fdd802f0290a3852a98c935bad
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-13T03:10:51Z

    Merge branch 'TAJO-1577_2' of https://github.com/jihoonson/tajo-2 into TAJO-1577_2

commit e7ac157f32a4a31e446683aec309575d9cbb8af7
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-13T11:01:46Z

    TestJoinOnPartitionedTables passed

commit 374fc1d75ac96ae35fb19ec660075d9ca8017110
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-13T11:39:56Z

    Passed TestJoinQuery

commit 97a2cc75f2f227a3545af27ffd26d513633225f8
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-13T12:26:44Z

    TAJO-1577_2

commit 0e6e838940d429334782c98f5f0d086622a5b80a
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-13T15:15:21Z

    TAJO-1577_2

commit 04e3b669aa7027ecb524531826e56e6e936f0d29
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-14T02:51:53Z

    TAJO-1577_2

commit 30b2cb8ff1ec1003d3e4e9b9f780bc38209d4ad0
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-14T03:42:34Z

    Passed all join tests

commit b8d70f11f2e6782f97c1ba85dd17fc87743fd273
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-14T07:00:12Z

    Add result files

commit 3822b10b8fb492cc887ee840a444daf4db0a93d0
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-14T10:13:05Z

    Verify results

commit db6c609dadffb11da8ad498d94fe3a6f8f9b9c1b
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-14T12:49:45Z

    Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1577_2

commit ad3b168f4532b6a7342ef76f05a937ad56c72754
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-14T13:44:48Z

    TAJO-1577_2

commit 53fea3f6523b5e4eadd68ff59b66eda9d7e99d51
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-14T14:45:21Z

    TAJO-1577_2

commit 92f45bbddfa33154d297143ba7fc97709757b9d9
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-15T02:55:35Z

    Reduce broadcast threadhold

commit 9b8f1cc980482ef1b0437661052ea3604dd7de15
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-15T04:47:26Z

    TAJO-1577_2

commit f74facbd4249dbe8b2ffd66179fffded9f4fc5c1
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-15T07:54:49Z

    TAJO-1577_2

commit e7e8a18e1f7f9933b44b97fabfcd49e7c1924800
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-15T10:38:26Z

    TAJO-1577_2

commit 70bb6e6247a4a56c26bcee8cfc399a2acd49dbc2
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-15T11:02:25Z

    TAJO-1577_2

commit 5d69edba7e2f185847b484044a63d1762ef01220
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-15T13:40:33Z

    Passed all tests

commit 19e67ca2e2690855e9a94abed2890847a5dd767d
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-15T13:44:42Z

    Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1577_2

commit f0c7a8df73e0d234bfd2759dadff74fa6cfa992e
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-15T13:46:56Z

    Remove commented out codes

commit ea1fc091ab70ac7499c84366a5ed9d1837fb4a15
Author: Jihoon Son <ji...@apache.org>
Date:   2015-05-15T13:53:48Z

    Merge master

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1577: Add test cases to verify join plans

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/571#issuecomment-103206900
  
    Great job! The patch looks good to me. The change looks straightforward. You may spend lots of time on changing many tests. 
    
    Here is my +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1577: Add test cases to verify join plans

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/571


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---