You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/01 15:30:20 UTC
[GitHub] [spark] cloud-fan commented on issue #24759:
[SPARK-27395][SQL][WIP] Improve EXPLAIN command
cloud-fan commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command
URL: https://github.com/apache/spark/pull/24759#issuecomment-517337839
This is a big improvement! I have several high-level comments
1. the `*(1)` prefix is pretty short. Shall we keep this in the head portion? It can give you a general sense about how is your query being whole-stage-codegened. If you worry about the codegen id may conflict with the operator id, we can omit it and only use `*` as the prefix.
2. it's a good idea to separate uncorrelated subqueries from the main query, but how about correlated subqueries? Can you give an example?
3. Shall we always include the statistics?
4. what's the general rule for each operator to display information? I think `input` always need to be included except the leaf node. What about others?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org