[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #2552: IGNITE-19106 Sql. Fix partially broken column namings

["ygerzhedovich (via GitHub)" <gi...@apache.org>]

ygerzhedovich commented on code in PR #2552:
URL: https://github.com/apache/ignite-3/pull/2552#discussion_r1316868670


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientSqlTest.java:
##########
@@ -213,8 +213,7 @@ void testExecuteAsyncDdlDml() throws InterruptedException {
         assertEquals(3, columns.size());
         assertEquals("MYVALUE", columns.get(0).name());
         assertEquals("ID", columns.get(1).name());
-        // TODO: Uncomment after https://issues.apache.org/jira/browse/IGNITE-19106 Column namings are partially broken
-        //assertEquals("ID + 1", columns.get(2).name());
+        assertEquals("TESTEXECUTEASYNCDDLDML.ID + 1", columns.get(2).name());

Review Comment:
   It looks incorrect to have schemaname as part of name of column



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org