[jira] [Commented] (MESOS-9279) Docker Containerizer 'usage' call might be expensive if mount table is big.

["Jie Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-9279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632657#comment-16632657 ] 

Jie Yu commented on MESOS-9279:
-------------------------------

commit 59b92a948fab386542f5ddfee275066694cf1f96 (HEAD -> master, origin/master, origin/HEAD, fix_docker_stats)
Author: Jie Yu <yu...@gmail.com>
Date:   Fri Sep 28 15:55:59 2018 -0700

    Cached the cgroup results in Docker containerizer.

    Since the cgroup hierarchy results won't change, it does not make sense
    to compute it every time `usage` is called. It will get quite expensivie
    when the host mount table is big (e.g., MESOS-8418).

    This patch uses the static local variable to cache the result.

    Review: https://reviews.apache.org/r/68880

> Docker Containerizer 'usage' call might be expensive if mount table is big.
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-9279
>                 URL: https://issues.apache.org/jira/browse/MESOS-9279
>             Project: Mesos
>          Issue Type: Bug
>          Components: containerization, docker
>    Affects Versions: 1.5.1, 1.6.1, 1.7.0
>            Reporter: Jie Yu
>            Priority: Major
>         Attachments: busy_agent_scale_test_0927.stacks, screenshot-1.png
>
>
> We observed in some testing environment that Docker Containerizer 'usage' call can become very expensive if the host mount table is big.
> Perf analysis shows that most of the time was spent on reading the mount table. This is similar to the problem we saw in MESOS-8418.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)