You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/19 22:50:25 UTC
[GitHub] [superset] betodealmeida opened a new pull request #18098: feat: command to sync DBT to Superset
betodealmeida opened a new pull request #18098:
URL: https://github.com/apache/superset/pull/18098
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR introduces a new command to sync metadata from [DBT](https://github.com/dbt-labs/dbt-core) to Superset. The command reads the profile and manifest files, creating/updating databases and datasets in Superset based on them.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Given this `~/.dbt/profiles.yml`:
```yaml
superset_examples:
outputs:
dev:
type: postgres
threads: 1
host: localhost
port: 5432
user: beto
pass: ''
dbname: examples_dev
schema: public
meta:
superset:
cache_timeout: 300 # arbitrary metadata for our DB
target: dev
```
The file `messages_channels.sql`:
```sql
SELECT
messages.ts,
channels.name,
messages.text
FROM
{{ source ('public', 'messages') }} messages
JOIN {{ source ('public', 'channels') }} channels ON messages.channel_id = channels.id
```
And `schema.yaml`:
```yaml
version: 2
sources:
- name: public
tables:
- name: messages
description: 'Messages in the Slack channel'
- name: channels
description: 'Information about Slack channels'
metrics:
- name: cnt
label: ''
model: ref('messages_channels')
description: ''
type: count
sql: '*'
```
We can run:
```bash
$ superset sync dbt \
> ~/Projects/dbt-examples/superset_examples/target/manifest.json \
> --project superset_examples \
> --target dev # not needed, default is already "dev"
```
This will (1) create (or update) the a new database connection based on Postgres:
It will also (2) create/update three datasets owner by the admin:
(Note that the dataset description comes from the DBT config.)
It will also populate metrics:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
1. Create a DBT project.
2. Run `superset sync dbt /path/to/project/target/manifest.json --project PROJECT --target TARGET`
Check that everything is imported correctly.
Currently, this only works for Postgres, but adding other [profile types](https://docs.getdbt.com/reference/profiles.yml) is straightforward.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida closed pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
betodealmeida closed pull request #18098:
URL: https://github.com/apache/superset/pull/18098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1016951828
# [Codecov](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18098](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4035ccb) into [master](https://codecov.io/gh/apache/superset/commit/9e2bc72fb9687eb1d4563fd02853fea6b94a978d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e2bc72) will **decrease** coverage by `0.12%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18098 +/- ##
==========================================
- Coverage 65.85% 65.73% -0.13%
==========================================
Files 1577 1581 +4
Lines 61828 61942 +114
Branches 6244 6244
==========================================
- Hits 40719 40715 -4
- Misses 19509 19627 +118
Partials 1600 1600
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `51.95% <0.00%> (-0.20%)` | :arrow_down: |
| mysql | `80.73% <0.00%> (-0.31%)` | :arrow_down: |
| postgres | `80.77% <0.00%> (-0.32%)` | :arrow_down: |
| presto | `51.79% <0.00%> (-0.20%)` | :arrow_down: |
| python | `81.21% <0.00%> (-0.33%)` | :arrow_down: |
| sqlite | `80.47% <0.00%> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/cli/celery.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL2NlbGVyeS5weQ==) | `0.00% <ø> (ø)` | |
| [superset/cli/main.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL21haW4ucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/cli/sync/dbt/command.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3N5bmMvZGJ0L2NvbW1hbmQucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/cli/sync/dbt/databases.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3N5bmMvZGJ0L2RhdGFiYXNlcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/cli/sync/dbt/datasets.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3N5bmMvZGJ0L2RhdGFzZXRzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/cli/sync/main.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3N5bmMvbWFpbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/cli/update.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3VwZGF0ZS5weQ==) | `0.00% <ø> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `85.71% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `89.13% <0.00%> (-2.18%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `95.08% <0.00%> (-0.55%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9e2bc72...4035ccb](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
rumbin commented on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1019082927
Beto, are you aware of this project?
https://github.com/slidoapp/dbt-superset-lineage
I haven't tried it, though...
Regarding your approach, I have some doubts on automatically updating the DB connection.
In many cases people may want to use a different user here, or different connection strings for the sake of things like user impersonation, proxy settings, roles, warehouse settings (Snowflake), etc.
I know that you are currently only covering Postgres, but for other databases it may become troublesome.
Maybe this step could be made optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1076890513
I'm working on a better solution for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rumbin commented on pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
rumbin commented on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1019322570
Sounds great.
What I haven't understood so far is, how you envision the setup of this solution. Where is the `superset sync dbt` run ideally? I suppose that this would be part of a CI/CD pipeline. So, what components of Superset need to be installed in the container?
We should also consider what would be suitable scenarios for dbt Cloud users who would first need to fetch the dbt artifacts via API calls.
BTW, I am not associated with the dbt-superset-lineage project in any way. I was just planning to give it a try in the near future. However, now I am curious to wait for your solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mrshu edited a comment on pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
mrshu edited a comment on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1019346133
> BTW, I am not associated with the dbt-superset-lineage project in any way. I was just planning to give it a try in the near future. However, now I am curious to wait for your solution.
@rumbin Being at least somewhat associated with it, although not one of the authors, please do not hesitate to reach out with feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1019296794
> Beto, are you aware of this project? https://github.com/slidoapp/dbt-superset-lineage I haven't tried it, though...
Yes, it was the inspiration! I should've mentioned it in the summary, I'll update it. I think both approaches are valid — this one here is simpler because you're using the CLI, while the other uses the API and is valuable for cases where you don't have direct access.
> Regarding your approach, I have some doubts on automatically updating the DB connection. In many cases people may want to use a different user here, or different connection strings for the sake of things like user impersonation, proxy settings, roles, warehouse settings (Snowflake), etc. I know that you are currently only covering Postgres, but for other databases it may become troublesome. Maybe this step could be made optional?
That's a great point! I'll make it optional, allowing the user to reuse an existing DB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mrshu commented on pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
mrshu commented on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1019346133
> BTW, I am not associated with the dbt-superset-lineage project in any way. I was just planning to give it a try in the near future. However, now I am curious to wait for your solution.
@rumbin Being at least somewhat associated with it, please do not hesitate to reach out with feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1020471580
> Sounds great. What I haven't understood so far is, how you envision the setup of this solution. Where is the `superset sync dbt` run ideally? I suppose that this would be part of a CI/CD pipeline. So, what components of Superset need to be installed in the container? We should also consider what would be suitable scenarios for dbt Cloud users who would first need to fetch the dbt artifacts via API calls.
To run it in CI/CD you would need to `pip install superset`, set `SUPERSET__SQLALCHEMY_DATABASE_URI`, and run `superset sync dbt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1016951828
# [Codecov](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18098](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4035ccb) into [master](https://codecov.io/gh/apache/superset/commit/9e2bc72fb9687eb1d4563fd02853fea6b94a978d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e2bc72) will **decrease** coverage by `0.30%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18098 +/- ##
==========================================
- Coverage 65.85% 65.55% -0.31%
==========================================
Files 1577 1581 +4
Lines 61828 61942 +114
Branches 6244 6244
==========================================
- Hits 40719 40604 -115
- Misses 19509 19738 +229
Partials 1600 1600
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `51.95% <0.00%> (-0.20%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `51.79% <0.00%> (-0.20%)` | :arrow_down: |
| python | `80.84% <0.00%> (-0.69%)` | :arrow_down: |
| sqlite | `80.47% <0.00%> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/cli/celery.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL2NlbGVyeS5weQ==) | `0.00% <ø> (ø)` | |
| [superset/cli/main.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL21haW4ucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/cli/sync/dbt/command.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3N5bmMvZGJ0L2NvbW1hbmQucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/cli/sync/dbt/databases.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3N5bmMvZGJ0L2RhdGFiYXNlcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/cli/sync/dbt/datasets.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3N5bmMvZGJ0L2RhdGFzZXRzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/cli/sync/main.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3N5bmMvbWFpbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/cli/update.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3VwZGF0ZS5weQ==) | `0.00% <ø> (ø)` | |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-56.87%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `60.34% <0.00%> (-20.69%)` | :arrow_down: |
| ... and [19 more](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9e2bc72...4035ccb](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1016951828
# [Codecov](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18098](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4035ccb) into [master](https://codecov.io/gh/apache/superset/commit/9e2bc72fb9687eb1d4563fd02853fea6b94a978d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e2bc72) will **decrease** coverage by `0.12%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18098 +/- ##
==========================================
- Coverage 65.85% 65.73% -0.13%
==========================================
Files 1577 1581 +4
Lines 61828 61942 +114
Branches 6244 6244
==========================================
Hits 40719 40719
- Misses 19509 19623 +114
Partials 1600 1600
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `51.95% <0.00%> (-0.20%)` | :arrow_down: |
| mysql | `80.73% <0.00%> (-0.31%)` | :arrow_down: |
| postgres | `80.78% <0.00%> (-0.31%)` | :arrow_down: |
| presto | `51.79% <0.00%> (-0.20%)` | :arrow_down: |
| python | `81.22% <0.00%> (-0.31%)` | :arrow_down: |
| sqlite | `80.47% <0.00%> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/cli/celery.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL2NlbGVyeS5weQ==) | `0.00% <ø> (ø)` | |
| [superset/cli/main.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL21haW4ucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/cli/sync/dbt/command.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3N5bmMvZGJ0L2NvbW1hbmQucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/cli/sync/dbt/databases.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3N5bmMvZGJ0L2RhdGFiYXNlcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/cli/sync/dbt/datasets.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3N5bmMvZGJ0L2RhdGFzZXRzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/cli/sync/main.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3N5bmMvbWFpbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/cli/update.py](https://codecov.io/gh/apache/superset/pull/18098/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3VwZGF0ZS5weQ==) | `0.00% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9e2bc72...4035ccb](https://codecov.io/gh/apache/superset/pull/18098?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1020471580
> Sounds great. What I haven't understood so far is, how you envision the setup of this solution. Where is the `superset sync dbt` run ideally? I suppose that this would be part of a CI/CD pipeline. So, what components of Superset need to be installed in the container? We should also consider what would be suitable scenarios for dbt Cloud users who would first need to fetch the dbt artifacts via API calls.
To run it in CI/CD you would need to `pip install superset`, set `SUPERSET__SQLALCHEMY_DATABASE_URI`, and run `superset sync dbt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] noel commented on pull request #18098: feat: command to sync DBT to Superset
Posted by GitBox <gi...@apache.org>.
noel commented on pull request #18098:
URL: https://github.com/apache/superset/pull/18098#issuecomment-1058522663
Based on a [conversation in the dbt Slack #tools-superset channel](https://getdbt.slack.com/archives/C02D6J37DK3/p1646318772053319)
It was suggested that I add a comment to this PR.
The idea is to create datasets automatically via a configuration in the dbt_profiles.yml
```
models:
project:
marts:
+superset_export: true
```
The above would create datasets for all the models in under *marts*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org