You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/05/19 05:14:32 UTC
[GitHub] [incubator-echarts-doc] plainheart opened a new pull request #99: feat: added missing events and actions docs of legend(selectall & inverseselect).
plainheart opened a new pull request #99:
URL: https://github.com/apache/incubator-echarts-doc/pull/99
Currently, events(`legendselectall` & `legendinverseselect`) and actions(`legendAllSelect` & `legendInverseSelect`) are missing for `legend` component.
Added them according to https://github.com/apache/incubator-echarts/blob/master/src/component/legend/legendAction.js#L82-L90
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] pissang commented on a change in pull request #99: feat: added missing events and actions docs of legend(selectall & inverseselect).
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #99:
URL: https://github.com/apache/incubator-echarts-doc/pull/99#discussion_r430162191
##########
File path: en/api/action.md
##########
@@ -92,6 +92,28 @@ dispatchAction({
**EVENT:** [legendselectchanged](~events.legendselectchanged)
+### legendAllSelect(Action)
+Selects all legends.
+
+```js
+dispatchAction({
+ type: 'legendAllSelect'
+})
+```
+
+**EVENT:** [legendselectall](~events.legendselectall)
+
+### legendInverseSelect(Action)
+Unselects all legends.
+
Review comment:
I think it's inverse selection instead of unselecting. It may change to selected status after button clicked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] plainheart commented on a change in pull request #99: feat: added missing events and actions docs of legend(selectall & inverseselect).
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #99:
URL: https://github.com/apache/incubator-echarts-doc/pull/99#discussion_r430201577
##########
File path: en/api/action.md
##########
@@ -92,6 +92,28 @@ dispatchAction({
**EVENT:** [legendselectchanged](~events.legendselectchanged)
+### legendAllSelect(Action)
+Selects all legends.
+
+```js
+dispatchAction({
+ type: 'legendAllSelect'
+})
+```
+
+**EVENT:** [legendselectall](~events.legendselectall)
+
+### legendInverseSelect(Action)
+Unselects all legends.
+
Review comment:
Yes~ That's my fault. I'm sure you are right. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] pissang merged pull request #99: feat: added missing events and actions docs of legend(selectall & inverseselect).
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #99:
URL: https://github.com/apache/incubator-echarts-doc/pull/99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org