[jira] Resolved: (JS1-418) GenricMVCAction.java navigation doesn't work

[je...@jakarta.apache.org]

Message:

   The following issue has been resolved as WON'T FIX.

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JS1-418

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JS1-418
    Summary: GenricMVCAction.java navigation doesn't work
       Type: Bug

     Status: Resolved
 Resolution: WON'T FIX

    Project: Jetspeed
 Components: 
             Portlets
   Versions:
             1.4

   Assignee: 
   Reporter: Andreas Herz

    Created: Fri, 14 Nov 2003 9:52 AM
    Updated: Sat, 28 Aug 2004 1:07 PM
Environment: Operating System: All
Platform: All

Description:
The doPerform(...) call in the catch block moved outside the catch block.

THE BUG:
========
    protected void perform(RunData rundata)
                    throws Exception
      {

        Context context = getContext(rundata);

        if ((context != null) && (rundata.getParameters().getString("action") !=
null))
          {

            // if context is already defined and Actions defined, events
            // have already been processed, call doPerform
            logger.debug("Action detected with action + context");
            doPerform(rundata, context);
          }
        else
          {

            // if context is null, create a new one
            if (context == null)
              {
                logger.debug("Action: building action context");
                context = new GenericMVCContext();
               
rundata.getTemplateInfo().setTemplateContext("VelocityActionContext", context);
              }

            try
              {

                // process implicit ActionEvent invocation
                logger.debug("Action: try executing events");

                GenericMVCPortlet portlet = (GenericMVCPortlet)
context.get("portlet");

                if (portlet != null)
                  {

                    // verify this portlet is the one requested by checking the
                    // js_peid request var.  If there is no js_peid
                    // do not worry a about verifing.  helps with backward compat.
                    if (rundata.getParameters().getString("js_peid") == null ||
PortletSessionState.isMyRequest(rundata, portlet))
                      {
                        executeEvents(rundata, context);
                      }
                    else
                      {
                        logger.debug("Action: calling doPerform");
                        doPerform(rundata, context);
                      }
                  }
                else
                  {
                    executeEvents(rundata, context);
                  }
              }
            catch (NoSuchMethodException e)
              {

                // no event selected, process normal context generation
                logger.debug("Action: calling doPerform");
              }
	doPerform(rundata, context);//<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
          }
      }

THE SOLUTION:
=============
    protected void perform(RunData rundata)
                    throws Exception
      {

        Context context = getContext(rundata);

        if ((context != null) && (rundata.getParameters().getString("action") !=
null))
          {

            // if context is already defined and Actions defined, events
            // have already been processed, call doPerform
            logger.debug("Action detected with action + context");
            doPerform(rundata, context);
          }
        else
          {

            // if context is null, create a new one
            if (context == null)
              {
                logger.debug("Action: building action context");
                context = new GenericMVCContext();
               
rundata.getTemplateInfo().setTemplateContext("VelocityActionContext", context);
              }

            try
              {

                // process implicit ActionEvent invocation
                logger.debug("Action: try executing events");

                GenericMVCPortlet portlet = (GenericMVCPortlet)
context.get("portlet");

                if (portlet != null)
                  {

                    // verify this portlet is the one requested by checking the
                    // js_peid request var.  If there is no js_peid
                    // do not worry a about verifing.  helps with backward compat.
                    if (rundata.getParameters().getString("js_peid") == null ||
PortletSessionState.isMyRequest(rundata, portlet))
                      {
                        executeEvents(rundata, context);
                      }
                    else
                      {
                        logger.debug("Action: calling doPerform");
                        doPerform(rundata, context);
                      }
                  }
                else
                  {
                    executeEvents(rundata, context);
                  }
              }
            catch (NoSuchMethodException e)
              {

                // no event selected, process normal context generation
                logger.debug("Action: calling doPerform");
	doPerform(rundata, context); //<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
              }
          }
      }


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org