You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/15 12:56:11 UTC
[GitHub] [incubator-nuttx] raiden00pl opened a new pull request, #6623: stm32f0l0g0: improvements for ADC
raiden00pl opened a new pull request, #6623:
URL: https://github.com/apache/incubator-nuttx/pull/6623
## Summary
- stm32f0l0g0: remove references to non-existent ADCs, only ADC1 present on STM32 M0/M0+ devices
## Impact
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #6623: stm32f0l0g0: improvements for ADC
Posted by GitBox <gi...@apache.org>.
acassis merged PR #6623:
URL: https://github.com/apache/incubator-nuttx/pull/6623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6623: stm32f0l0g0: improvements for ADC
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #6623:
URL: https://github.com/apache/incubator-nuttx/pull/6623#discussion_r922151882
##########
arch/arm/src/stm32f0l0g0/hardware/stm32_adc.h:
##########
@@ -75,18 +75,11 @@
* Pre-processor Definitions
****************************************************************************/
-#define STM32_ADC1_OFFSET 0x0000
-#define STM32_ADC2_OFFSET 0x0100
-#define STM32_ADC3_OFFSET 0x0000
-#define STM32_ADC4_OFFSET 0x0100
#define STM32_ADCCMN_OFFSET 0x0300
-#define STM32_ADC1_BASE (STM32_ADC1_OFFSET+STM32_ADC12_BASE) /* ADC1 Master ADC */
-#define STM32_ADC2_BASE (STM32_ADC2_OFFSET+STM32_ADC12_BASE) /* ADC2 Slave ADC */
-#define STM32_ADC3_BASE (STM32_ADC3_OFFSET+STM32_ADC34_BASE) /* ADC3 Master ADC */
-#define STM32_ADC4_BASE (STM32_ADC4_OFFSET+STM32_ADC34_BASE) /* ADC4 Slave ADC */
-#define STM32_ADC12CMN_BASE (STM32_ADCCMN_OFFSET+STM32_ADC12_BASE) /* ADC1, ADC2 common */
-#define STM32_ADC34CMN_BASE (STM32_ADCCMN_OFFSET+STM32_ADC34_BASE) /* ADC3, ADC4 common */
+/* ADC1, ADC2 common - ADC2 not present on STM32 M0/M0+ devices */
+
+#define STM32_ADC12CMN_BASE (STM32_ADCCMN_OFFSET+STM32_ADC1_BASE)
Review Comment:
Since ADC2 is not present, why not get rid of STM32_ADC12CMN_BASE ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on a diff in pull request #6623: stm32f0l0g0: improvements for ADC
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on code in PR #6623:
URL: https://github.com/apache/incubator-nuttx/pull/6623#discussion_r922161619
##########
arch/arm/src/stm32f0l0g0/hardware/stm32_adc.h:
##########
@@ -75,18 +75,11 @@
* Pre-processor Definitions
****************************************************************************/
-#define STM32_ADC1_OFFSET 0x0000
-#define STM32_ADC2_OFFSET 0x0100
-#define STM32_ADC3_OFFSET 0x0000
-#define STM32_ADC4_OFFSET 0x0100
#define STM32_ADCCMN_OFFSET 0x0300
-#define STM32_ADC1_BASE (STM32_ADC1_OFFSET+STM32_ADC12_BASE) /* ADC1 Master ADC */
-#define STM32_ADC2_BASE (STM32_ADC2_OFFSET+STM32_ADC12_BASE) /* ADC2 Slave ADC */
-#define STM32_ADC3_BASE (STM32_ADC3_OFFSET+STM32_ADC34_BASE) /* ADC3 Master ADC */
-#define STM32_ADC4_BASE (STM32_ADC4_OFFSET+STM32_ADC34_BASE) /* ADC4 Slave ADC */
-#define STM32_ADC12CMN_BASE (STM32_ADCCMN_OFFSET+STM32_ADC12_BASE) /* ADC1, ADC2 common */
-#define STM32_ADC34CMN_BASE (STM32_ADCCMN_OFFSET+STM32_ADC34_BASE) /* ADC3, ADC4 common */
+/* ADC1, ADC2 common - ADC2 not present on STM32 M0/M0+ devices */
+
+#define STM32_ADC12CMN_BASE (STM32_ADCCMN_OFFSET+STM32_ADC1_BASE)
Review Comment:
Mainly for compliance with stm32/stm32_adc_v2.h. This is basically a simplified version of what can be found in the arch/stm32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6623: stm32f0l0g0: improvements for ADC
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #6623:
URL: https://github.com/apache/incubator-nuttx/pull/6623#discussion_r922165146
##########
arch/arm/src/stm32f0l0g0/hardware/stm32_adc.h:
##########
@@ -75,18 +75,11 @@
* Pre-processor Definitions
****************************************************************************/
-#define STM32_ADC1_OFFSET 0x0000
-#define STM32_ADC2_OFFSET 0x0100
-#define STM32_ADC3_OFFSET 0x0000
-#define STM32_ADC4_OFFSET 0x0100
#define STM32_ADCCMN_OFFSET 0x0300
-#define STM32_ADC1_BASE (STM32_ADC1_OFFSET+STM32_ADC12_BASE) /* ADC1 Master ADC */
-#define STM32_ADC2_BASE (STM32_ADC2_OFFSET+STM32_ADC12_BASE) /* ADC2 Slave ADC */
-#define STM32_ADC3_BASE (STM32_ADC3_OFFSET+STM32_ADC34_BASE) /* ADC3 Master ADC */
-#define STM32_ADC4_BASE (STM32_ADC4_OFFSET+STM32_ADC34_BASE) /* ADC4 Slave ADC */
-#define STM32_ADC12CMN_BASE (STM32_ADCCMN_OFFSET+STM32_ADC12_BASE) /* ADC1, ADC2 common */
-#define STM32_ADC34CMN_BASE (STM32_ADCCMN_OFFSET+STM32_ADC34_BASE) /* ADC3, ADC4 common */
+/* ADC1, ADC2 common - ADC2 not present on STM32 M0/M0+ devices */
+
+#define STM32_ADC12CMN_BASE (STM32_ADCCMN_OFFSET+STM32_ADC1_BASE)
Review Comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org