You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/08 22:25:11 UTC
[GitHub] [airflow] bbovenzi opened a new pull request #14141: Update Tree View date ticks
bbovenzi opened a new pull request #14141:
URL: https://github.com/apache/airflow/pull/14141
Updated the x-axis a DAG's `Tree View`. Switched from x3's date to linear scale to add extra logic for adding/formatting ticks.
- Dates on the axis will better line up with the dates shown in each box's tooltip
- Prevent tick text overlapping
- Properly format all tick dates to prevent millisecond count showing up sometimes
closes: #14046
------------------ BEFORE ------------------
<img width="649" alt="Screen Shot 2021-02-08 at 4 17 09 PM" src="https://user-images.githubusercontent.com/4600967/107289017-03366800-6a2a-11eb-9502-dc79795b46e7.png">
<img width="378" alt="Screen Shot 2021-02-08 at 4 17 13 PM" src="https://user-images.githubusercontent.com/4600967/107289006-fd408700-6a29-11eb-8fd6-040dbc6dda59.png">
------------------ AFTER ------------------
<img width="154" alt="Screen Shot 2021-02-08 at 4 19 55 PM" src="https://user-images.githubusercontent.com/4600967/107289032-09c4df80-6a2a-11eb-9c58-f70b606db8b3.png">
<img width="111" alt="Screen Shot 2021-02-08 at 4 20 04 PM" src="https://user-images.githubusercontent.com/4600967/107289062-15180b00-6a2a-11eb-9452-20deb1208eb8.png">
<img width="335" alt="Screen Shot 2021-02-08 at 4 17 42 PM" src="https://user-images.githubusercontent.com/4600967/107289070-18ab9200-6a2a-11eb-944c-06dbe6e0c817.png">
<img width="116" alt="Screen Shot 2021-02-08 at 4 18 23 PM" src="https://user-images.githubusercontent.com/4600967/107289095-2234fa00-6a2a-11eb-820a-e8d14ba3fea0.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14141: Update Tree View date ticks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14141:
URL: https://github.com/apache/airflow/pull/14141#issuecomment-778336846
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14141: Update Tree View date ticks
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14141:
URL: https://github.com/apache/airflow/pull/14141#issuecomment-775851320
> Right now its formatted in the local timezone as opposed to UTC.
It should use whatever time zone is selected in the UI.
Additionally: Just using MMM DD may not be enough -- if you have an hourly dag for instance, that's going to show lots of the same date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #14141: Update Tree View date ticks
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on pull request #14141:
URL: https://github.com/apache/airflow/pull/14141#issuecomment-776179188
@ashb added the HH:mm too
<img width="548" alt="Screen Shot 2021-02-09 at 1 19 20 PM" src="https://user-images.githubusercontent.com/4600967/107415890-6f23d980-6ad9-11eb-8872-5c4f4ba154b6.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #14141: Update Tree View date ticks
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #14141:
URL: https://github.com/apache/airflow/pull/14141
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org