You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/03 22:01:09 UTC

[GitHub] [airflow] AmarEL opened a new pull request #15181: Create the S3MultipleKeySensor for the s3 service for aws provider

AmarEL opened a new pull request #15181:
URL: https://github.com/apache/airflow/pull/15181


   For cases where is needed to wait for multiples keys to exist on s3, this operator could help
   
   closes: #15001
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] closed pull request #15181: Create the S3MultipleKeySensor for the s3 service for aws provider

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #15181:
URL: https://github.com/apache/airflow/pull/15181


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #15181: Create the S3MultipleKeySensor for the s3 service for aws provider

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15181:
URL: https://github.com/apache/airflow/pull/15181#issuecomment-813080271


   > I'm still not convinced that we need a new operator for this.
   > I prefer the approach suggested in the #15001
   > enhanced`S3PrefixSensor` by changing prefix to accept `str or List[str]` that way it also backward compatible.
   > 
   > I'm -0 for this change by won't get in the way if other find this approach better.
   
   Agree with @eladkal. Would be much better to accept List[] in the existing sensor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #15181: Create the S3MultipleKeySensor for the s3 service for aws provider

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15181:
URL: https://github.com/apache/airflow/pull/15181#issuecomment-812965409


   [The Workflow run](https://github.com/apache/airflow/actions/runs/715736172) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #15181: Create the S3MultipleKeySensor for the s3 service for aws provider

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15181:
URL: https://github.com/apache/airflow/pull/15181#issuecomment-846315965


   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on pull request #15181: Create the S3MultipleKeySensor for the s3 service for aws provider

Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #15181:
URL: https://github.com/apache/airflow/pull/15181#issuecomment-813069882


   I'm still not convinced that we need a new operator for this.
   I prefer the approach suggested in the https://github.com/apache/airflow/issues/15001
   enhanced`S3PrefixSensor` by changing prefix to accept `str or List[str]` that way it also backward compatible.
   
   I'm -0 for this change by won't get in the way if other find this approach better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org