You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/10/03 20:21:23 UTC

[GitHub] mrutkows commented on issue #580: Add the support of the key 'packages' in deployment.yaml

mrutkows commented on issue #580: Add the support of the key 'packages' in deployment.yaml
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/580#issuecomment-333966278
 
 
   @houshengbo @pritidesai notice now how we now have 2 structures that are exactly the same now in yamlparser.go..
   
   ```
   type DeploymentYAML struct {
   	Application Application       `yaml:"application"` //used in deployment.yaml
       Packages   map[string]Package `yaml:"packages"` //used in deployment.yaml
       Package    Package            `yaml:"package"`
   	Filepath    string      //file path of the yaml file
   }
   
   type ManifestYAML struct {
   	Package  Package `yaml:"package"` //used in both manifest.yaml and deployment.yaml
   	Packages map[string]Package `yaml:"packages"`
   	Filepath string  //file path of the yaml file
       Application Application       `yaml:"application"` //used in manifest.yaml
   }
   ```
   
   time for a simplification? or is there value (future?) keeping them separated?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services