You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/07/22 20:30:07 UTC
[kudu-CR] [make site.h] added C++ client API documentaion
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3729
Change subject: [make_site.h] added C++ client API documentaion
......................................................................
[make_site.h] added C++ client API documentaion
The C++ client API documentation is auto-generated by doxygen.
The top-level file is 'index.html' file in the 'cpp_client_api'
sub-directory of the site contents.
Change-Id: I9347f515ed4e1e0e3a5d46c969e57fe4983f17e2
---
M docs/support/scripts/make_site.sh
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/3729/1
--
To view, visit http://gerrit.cloudera.org:8080/3729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9347f515ed4e1e0e3a5d46c969e57fe4983f17e2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [make site.h] added C++ client API documentaion
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [make_site.h] added C++ client API documentaion
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2643/
--
To view, visit http://gerrit.cloudera.org:8080/3729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9347f515ed4e1e0e3a5d46c969e57fe4983f17e2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [make site.h] added C++ client API documentaion
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [make_site.h] added C++ client API documentaion
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3729/1/docs/support/scripts/make_site.sh
File docs/support/scripts/make_site.sh:
Line 80: rm -Rf "$SITE_OUTPUT_DIR/cpp_client_api"
Please use hyphens instead of underscores to separate the words (for SEO reasons per http://www.ecreativeim.com/blog/2011/03/seo-basics-hyphen-or-underscore-for-seo-urls/ ) so how about "cpp-client-api" here and below
--
To view, visit http://gerrit.cloudera.org:8080/3729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9347f515ed4e1e0e3a5d46c969e57fe4983f17e2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [make site.h] added C++ client API documentaion
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [make_site.h] added C++ client API documentaion
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2634/
--
To view, visit http://gerrit.cloudera.org:8080/3729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9347f515ed4e1e0e3a5d46c969e57fe4983f17e2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [make site.h] added C++ client API documentaion
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: [make_site.h] added C++ client API documentaion
......................................................................
[make_site.h] added C++ client API documentaion
The C++ client API documentation is auto-generated by doxygen.
The top-level file is 'index.html' file in the 'cpp_client_api'
sub-directory of the site contents.
Change-Id: I9347f515ed4e1e0e3a5d46c969e57fe4983f17e2
Reviewed-on: http://gerrit.cloudera.org:8080/3729
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Mike Percy <mp...@apache.org>
---
M docs/support/scripts/make_site.sh
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/3729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9347f515ed4e1e0e3a5d46c969e57fe4983f17e2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [make site.h] added C++ client API documentaion
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [make_site.h] added C++ client API documentaion
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9347f515ed4e1e0e3a5d46c969e57fe4983f17e2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [make site.h] added C++ client API documentaion
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3729
to look at the new patch set (#2).
Change subject: [make_site.h] added C++ client API documentaion
......................................................................
[make_site.h] added C++ client API documentaion
The C++ client API documentation is auto-generated by doxygen.
The top-level file is 'index.html' file in the 'cpp_client_api'
sub-directory of the site contents.
Change-Id: I9347f515ed4e1e0e3a5d46c969e57fe4983f17e2
---
M docs/support/scripts/make_site.sh
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/3729/2
--
To view, visit http://gerrit.cloudera.org:8080/3729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9347f515ed4e1e0e3a5d46c969e57fe4983f17e2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [make site.h] added C++ client API documentaion
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [make_site.h] added C++ client API documentaion
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9347f515ed4e1e0e3a5d46c969e57fe4983f17e2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [make site.h] added C++ client API documentaion
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [make_site.h] added C++ client API documentaion
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3729/1/docs/support/scripts/make_site.sh
File docs/support/scripts/make_site.sh:
Line 80: rm -Rf "$SITE_OUTPUT_DIR/cpp_client_api"
> Please use hyphens instead of underscores to separate the words (for SEO re
Done
--
To view, visit http://gerrit.cloudera.org:8080/3729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9347f515ed4e1e0e3a5d46c969e57fe4983f17e2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes