[GitHub] [kafka] C0urante commented on a change in pull request #11526: KAFKA-13472: Correct last-committed offsets tracking for sink tasks after partial revocation

[GitBox <gi...@apache.org>]

C0urante commented on a change in pull request #11526:
URL: https://github.com/apache/kafka/pull/11526#discussion_r755504329



##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java
##########
@@ -654,6 +655,7 @@ private void closePartitions(Collection<TopicPartition> topicPartitions, boolean
             topicPartitions.forEach(currentOffsets::remove);
         }
         updatePartitionCount();
+        topicPartitions.forEach(lastCommittedOffsets::remove);

Review comment:
       Ah, neat trick. Ran unit+integration tests locally after making this change and they all passed; looks like the operation is supported.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org