[GitHub] [incubator-druid] gianm commented on a change in pull request #7540: call threadlocal.remove explicitly to avoid CPU usage spikes

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #7540: call threadlocal.remove explicitly to avoid CPU usage spikes
URL: https://github.com/apache/incubator-druid/pull/7540#discussion_r278175734
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ConcurrentGrouper.java
 ##########
 @@ -409,6 +409,7 @@ public void close()
   {
     if (!closed) {
       closed = true;
+      threadLocalGrouper.remove();
 
 Review comment:
   Is this going to solve the problem? If I understand correctly, `close()` will get called one time (by the thread that is reading aggregated values out of the ConcurrentGrouper) but none of those threads actually own a ThreadLocal Grouper (the threads that own those Groupers are processing-pool threads).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org