i18n code build system

[Garrett Rooney <ro...@electricjellyfish.net>]

So, if the i18n code is going to be separate from the rest of Abdera
(i.e. we're planning on moving it out of the tree eventually) would it
be possible to extract its build logic from build/build.xml?  I was
thinking of updating my work-in-progress ivy patch today, but I don't
want to totally duplicate the current logic to build the i18n stuff.
It seems like we could just put a stupidly-simple build.xml in
dependencies/i18n, and since we are trying to make that code
independent it's going to need that eventually anyway...

-garrett

Re: i18n code build system

[Adam Constabaris <ad...@clownsinmycoffee.net>]

Garrett Rooney wrote:
> On 3/27/07, Adam Constabaris <ad...@clownsinmycoffee.net> wrote:
>> James M Snell wrote:
>> > Heh... no patch attached :-)
>> >
>> >
>> It's not been the best week ... I spent the last ten minutes setting up
>> thunderbird (so long Mail.App).
>>
>> fingers crossed!
>
> I committed this with tweaks in r531309, although I can't test the
> entire maven build because the json stuff is totally failing to build
> for me (complaining about duplicated classes or some such nonsense).
>
> -garrett
cheers!

The "duplicate classes" errors, I think, are an artifact of build 
history; the ant build unpacks the json sources to:

dependencies/json/src/main/java

while maven unpacks them to:

dependencies/json/target/generated-sources/main/java

Both locations are on the build path when maven executes its "compile" 
target, so you get the duplicate class errors if you've already built 
json with ant. You can remove the files generated by ant, which aren't 
in SVN, and it should compile with maven.

If switching back and forth between ant and maven is desirable, I don't 
think it's too much work to harmonize the build processes in this 
particular instance, but that sets a bad precedent.  Are there strong 
objections to dropping one of the build tools?

[ OTOH, if this really is a one-off sort of problem, another option 
would be to see if the json.org folks -- or designated agents thereof -- 
can be persuaded to put their Apache-licenced binaries jars into the 
maven repositories, or switch to a json library that is in the maven 
repositories (json-lib, which is Apache licensed, but about which I know 
little else) ]

AC

Re: i18n code build system

[Garrett Rooney <ro...@electricjellyfish.net>]

On 3/27/07, Adam Constabaris <ad...@clownsinmycoffee.net> wrote:
> James M Snell wrote:
> > Heh... no patch attached :-)
> >
> >
> It's not been the best week ... I spent the last ten minutes setting up
> thunderbird (so long Mail.App).
>
> fingers crossed!

I committed this with tweaks in r531309, although I can't test the
entire maven build because the json stuff is totally failing to build
for me (complaining about duplicated classes or some such nonsense).

-garrett

Re: i18n code build system

[Adam Constabaris <ad...@clownsinmycoffee.net>]

James M Snell wrote:
> Heh... no patch attached :-)
>
>   
It's not been the best week ... I spent the last ten minutes setting up 
thunderbird (so long Mail.App).

fingers crossed!

AC

Re: i18n code build system

[James M Snell <ja...@gmail.com>]

Heh... no patch attached :-)

Adam Constabaris wrote:
> 
> On 27-Mar-07, at 5:03 AM, Garrett Rooney wrote:
> 
>> On 3/26/07, Adam Constabaris <ad...@clownsinmycoffee.net> wrote:
>>>
>>> On 26-Mar-07, at 12:46 AM, James M Snell wrote:
>>>
>>> > Excellent.  Feel free to post the patch here or in jira and I'll
>>> > get it
>>> > applied.
>>> >
>>> > - James
>>>
>>> My patch-fu being weak (darned if I can figure out how to create a
>>> complete patchset with svn diff in a timely fashion)
>>
>> Um, just run 'svn add' on the new files, then run 'svn diff'.
> 
> B'oh.  I plead seasonal allergies ...
> 
> Unified patch attached.
> 
> 
> 
>>
>> -garrett
> 

Re: i18n code build system

[Adam Constabaris <ad...@clownsinmycoffee.net>]

On 27-Mar-07, at 5:03 AM, Garrett Rooney wrote:

> On 3/26/07, Adam Constabaris <ad...@clownsinmycoffee.net> wrote:
>>
>> On 26-Mar-07, at 12:46 AM, James M Snell wrote:
>>
>> > Excellent.  Feel free to post the patch here or in jira and I'll
>> > get it
>> > applied.
>> >
>> > - James
>>
>> My patch-fu being weak (darned if I can figure out how to create a
>> complete patchset with svn diff in a timely fashion)
>
> Um, just run 'svn add' on the new files, then run 'svn diff'.

B'oh.  I plead seasonal allergies ...

Unified patch attached.

Re: i18n code build system

[Garrett Rooney <ro...@electricjellyfish.net>]

On 3/26/07, Adam Constabaris <ad...@clownsinmycoffee.net> wrote:
>
> On 26-Mar-07, at 12:46 AM, James M Snell wrote:
>
> > Excellent.  Feel free to post the patch here or in jira and I'll
> > get it
> > applied.
> >
> > - James
>
> My patch-fu being weak (darned if I can figure out how to create a
> complete patchset with svn diff in a timely fashion)

Um, just run 'svn add' on the new files, then run 'svn diff'.

-garrett

Re: i18n code build system

[Adam Constabaris <ad...@clownsinmycoffee.net>]

Argh ... hopefully, here are the two files that didn't make it  
through the first time ...

sheepishly,

AC

Re: i18n code build system

[Adam Constabaris <ad...@clownsinmycoffee.net>]

On 26-Mar-07, at 12:46 AM, James M Snell wrote:

> Excellent.  Feel free to post the patch here or in jira and I'll  
> get it
> applied.
>
> - James

My patch-fu being weak (darned if I can figure out how to create a  
complete patchset with svn diff in a timely fashion), I've
attached the following:

1. i18n.patch (root and core poms)
2. build.xml (dependencies/i18n/build.xml)
3. build.properties (dependencies/i18n/build.properties)
4. pom.xml (dependencies/i18n/pom.xml)

The way I approached it, it would probably make slightly more sense  
to move the i18n directory up to be a submodule, so it could take  
better advantage of maven inheritance.  Also, a warning: I changed  
the version to 0.3.0-incubating-SNAPSHOT, which is what both the new  
POM and new build.xml create.  There's no change to the master  
build.xml, so the new build.xml is not invoked unless it's done  
manually.   I hope it's still useful =)

(additional conditional apologies in advance, since I'm using  
Mail.App attachments for the first time)

cheers,

AC

Re: i18n code build system

[James M Snell <ja...@gmail.com>]

Excellent.  Feel free to post the patch here or in jira and I'll get it
applied.

- James

Adam Constabaris wrote:
> This isn't directly related, but I do have a pom for the i18n
> dependency, which also requires patching the pom for the core
> subproject.  If nobody's yet done a build.xml, I'll take a look at
> generating one of those and submitting a patch.
> 
> cheers,
> 
> AC
> 
> On 24-Mar-07, at 3:19 PM, James M Snell wrote:
> 
>> +1. that's been on my todo list.  It wouldn't break my heart if someone
>> else got to it first ;-)
>>
>> - James
>>
>> Garrett Rooney wrote:
>>> So, if the i18n code is going to be separate from the rest of Abdera
>>> (i.e. we're planning on moving it out of the tree eventually) would it
>>> be possible to extract its build logic from build/build.xml?  I was
>>> thinking of updating my work-in-progress ivy patch today, but I don't
>>> want to totally duplicate the current logic to build the i18n stuff.
>>> It seems like we could just put a stupidly-simple build.xml in
>>> dependencies/i18n, and since we are trying to make that code
>>> independent it's going to need that eventually anyway...
>>>
>>> -garrett
>>>
> 
> 

Re: i18n code build system

[Adam Constabaris <ad...@clownsinmycoffee.net>]

This isn't directly related, but I do have a pom for the i18n  
dependency, which also requires patching the pom for the core  
subproject.  If nobody's yet done a build.xml, I'll take a look at  
generating one of those and submitting a patch.

cheers,

AC

On 24-Mar-07, at 3:19 PM, James M Snell wrote:

> +1. that's been on my todo list.  It wouldn't break my heart if  
> someone
> else got to it first ;-)
>
> - James
>
> Garrett Rooney wrote:
>> So, if the i18n code is going to be separate from the rest of Abdera
>> (i.e. we're planning on moving it out of the tree eventually)  
>> would it
>> be possible to extract its build logic from build/build.xml?  I was
>> thinking of updating my work-in-progress ivy patch today, but I don't
>> want to totally duplicate the current logic to build the i18n stuff.
>> It seems like we could just put a stupidly-simple build.xml in
>> dependencies/i18n, and since we are trying to make that code
>> independent it's going to need that eventually anyway...
>>
>> -garrett
>>

Re: i18n code build system

[James M Snell <ja...@gmail.com>]

+1. that's been on my todo list.  It wouldn't break my heart if someone
else got to it first ;-)

- James

Garrett Rooney wrote:
> So, if the i18n code is going to be separate from the rest of Abdera
> (i.e. we're planning on moving it out of the tree eventually) would it
> be possible to extract its build logic from build/build.xml?  I was
> thinking of updating my work-in-progress ivy patch today, but I don't
> want to totally duplicate the current logic to build the i18n stuff.
> It seems like we could just put a stupidly-simple build.xml in
> dependencies/i18n, and since we are trying to make that code
> independent it's going to need that eventually anyway...
> 
> -garrett
>