You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "pvillard31 (via GitHub)" <gi...@apache.org> on 2026/01/06 18:58:47 UTC
[PR] NIFI-15432 Add system tests to code coverage workflow [nifi]
pvillard31 opened a new pull request, #10735:
URL: https://github.com/apache/nifi/pull/10735
# Summary
NIFI-15432 Add system tests to code coverage workflow
- Add system-tests job to collect coverage from spawned NiFi instances
- Configure JaCoCo agent injection via JACOCO_AGENT_PATH environment variable
- Modify SpawnedStandaloneNiFiInstanceFactory to configure JaCoCo agent in bootstrap.conf
- Collect and merge jacoco.exec files from system tests and stateless tests
- Convert merged coverage data to XML format for Codecov upload
- Dynamically extract module list from nifi-code-coverage/pom.xml
- Add nifi-registry-integration-tests profile to integration tests job
When doing testing in my fork, it's getting us to 60%+ of coverage.
https://app.codecov.io/github/pvillard31/nifi/commit/ec991a105874edbd925a95bb6eea9c2d060561e1/tree
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
- [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15432 Add system tests to code coverage workflow [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #10735:
URL: https://github.com/apache/nifi/pull/10735#issuecomment-3718229319
Thanks for the feedback @exceptionfactory - I extracted the scripting into an external dedicated script file. Given the nature of the system tests and how they work / are executed, I didn't find any other (better) option during my testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15432 Add system tests to code coverage workflow [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #10735:
URL: https://github.com/apache/nifi/pull/10735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org