You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "YvCeung (via GitHub)" <gi...@apache.org> on 2025/06/24 10:05:52 UTC
[PR] test:improve unit test coverage of seata-gRPC moudle [incubator-seata]
YvCeung opened a new pull request, #7464:
URL: https://github.com/apache/incubator-seata/pull/7464
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
test:improve unit test coverage of seata-gRPC moudle
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
#7384
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
mvn clean test
### Ⅴ. Special notes for reviews
During the process of reading the source code, I added some comments. Besides, I also found some unused variables, and then I deleted them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:improve unit test coverage of seata-gRPC moudle [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #7464:
URL: https://github.com/apache/incubator-seata/pull/7464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:improve unit test coverage of seata-gRPC moudle [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7464:
URL: https://github.com/apache/incubator-seata/pull/7464#issuecomment-2999701989
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7464?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 60.28%. Comparing base [(`cbc6ac5`)](https://app.codecov.io/gh/apache/incubator-seata/commit/cbc6ac5ad0aa89e0085d06817f995b6bf949d767?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e0b6f36`)](https://app.codecov.io/gh/apache/incubator-seata/commit/e0b6f3664c07595b8a18ef1e925587f1c8ebd2da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #7464 +/- ##
============================================
+ Coverage 60.21% 60.28% +0.06%
Complexity 658 658
============================================
Files 1281 1281
Lines 48282 48281 -1
Branches 5676 5676
============================================
+ Hits 29075 29107 +32
+ Misses 16602 16566 -36
- Partials 2605 2608 +3
```
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7464?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/grpc/interceptor/server/ServerListenerProxy.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7464?src=pr&el=tree&filepath=integration%2Fgrpc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fintegration%2Fgrpc%2Finterceptor%2Fserver%2FServerListenerProxy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZWdyYXRpb24vZ3JwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvaW50ZWdyYXRpb24vZ3JwYy9pbnRlcmNlcHRvci9zZXJ2ZXIvU2VydmVyTGlzdGVuZXJQcm94eS5qYXZh) | `88.88% <ø> (+88.88%)` | :arrow_up: |
| [...terceptor/server/ServerTransactionInterceptor.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7464?src=pr&el=tree&filepath=integration%2Fgrpc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fintegration%2Fgrpc%2Finterceptor%2Fserver%2FServerTransactionInterceptor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZWdyYXRpb24vZ3JwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvaW50ZWdyYXRpb24vZ3JwYy9pbnRlcmNlcHRvci9zZXJ2ZXIvU2VydmVyVHJhbnNhY3Rpb25JbnRlcmNlcHRvci5qYXZh) | `83.33% <ø> (+83.33%)` | :arrow_up: |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7464/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org