You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/03 04:03:03 UTC

[GitHub] [pulsar] Anonymitaet opened a new pull request #7440: Update Kingsoft logo

Anonymitaet opened a new pull request #7440:
URL: https://github.com/apache/pulsar/pull/7440


   Fix the issue of Kingsoft logo is not displayed
   
   ![image](https://user-images.githubusercontent.com/50226895/86430473-f24fa680-bd24-11ea-83a0-4304434f4d75.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie commented on a change in pull request #7440: Update Kingsoft logo

Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #7440:
URL: https://github.com/apache/pulsar/pull/7440#discussion_r449388079



##########
File path: site2/docs/tiered-storage-aws.md
##########
@@ -47,14 +47,13 @@ This example uses Pulsar 2.5.1.
 
     **Output**
 
-    As shown from the output, Pulsar uses [Apache jclouds](https://jclouds.apache.org) to support [AWS S3](https://aws.amazon.com/s3/) and [GCS](https://cloud.google.com/storage/) for long term storage. 

Review comment:
       Why do you change this file?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #7440: Update Kingsoft logo

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #7440:
URL: https://github.com/apache/pulsar/pull/7440#discussion_r449395183



##########
File path: site2/docs/tiered-storage-aws.md
##########
@@ -47,14 +47,13 @@ This example uses Pulsar 2.5.1.
 
     **Output**
 
-    As shown from the output, Pulsar uses [Apache jclouds](https://jclouds.apache.org) to support [AWS S3](https://aws.amazon.com/s3/) and [GCS](https://cloud.google.com/storage/) for long term storage. 

Review comment:
       It does not display correctly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet closed pull request #7440: Update Kingsoft logo

Posted by GitBox <gi...@apache.org>.
Anonymitaet closed pull request #7440:
URL: https://github.com/apache/pulsar/pull/7440


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] jiazhai commented on a change in pull request #7440: Update Kingsoft logo

Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #7440:
URL: https://github.com/apache/pulsar/pull/7440#discussion_r449886673



##########
File path: site2/docs/tiered-storage-aws.md
##########
@@ -47,14 +47,13 @@ This example uses Pulsar 2.5.1.
 
     **Output**
 
-    As shown from the output, Pulsar uses [Apache jclouds](https://jclouds.apache.org) to support [AWS S3](https://aws.amazon.com/s3/) and [GCS](https://cloud.google.com/storage/) for long term storage. 

Review comment:
       But this is not related with this change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #7440: Update Kingsoft logo

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #7440:
URL: https://github.com/apache/pulsar/pull/7440#discussion_r449395183



##########
File path: site2/docs/tiered-storage-aws.md
##########
@@ -47,14 +47,13 @@ This example uses Pulsar 2.5.1.
 
     **Output**
 
-    As shown from the output, Pulsar uses [Apache jclouds](https://jclouds.apache.org) to support [AWS S3](https://aws.amazon.com/s3/) and [GCS](https://cloud.google.com/storage/) for long term storage. 

Review comment:
       It does not display correctly. So I change it to:
   ![image](https://user-images.githubusercontent.com/50226895/86438008-4adc6f00-bd38-11ea-97be-f25f2c90c022.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on a change in pull request #7440: Update Kingsoft logo

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #7440:
URL: https://github.com/apache/pulsar/pull/7440#discussion_r449940501



##########
File path: site2/docs/tiered-storage-aws.md
##########
@@ -47,14 +47,13 @@ This example uses Pulsar 2.5.1.
 
     **Output**
 
-    As shown from the output, Pulsar uses [Apache jclouds](https://jclouds.apache.org) to support [AWS S3](https://aws.amazon.com/s3/) and [GCS](https://cloud.google.com/storage/) for long term storage. 

Review comment:
       @jiazhai this change is not related to logo, just fix issues together.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org