You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "arjun4084346 (via GitHub)" <gi...@apache.org> on 2023/06/07 20:19:39 UTC
[GitHub] [gobblin] arjun4084346 opened a new pull request, #3702: [TBD] avoid dependency from iceberg-hive-runtime which is a shaded fat jar
arjun4084346 opened a new pull request, #3702:
URL: https://github.com/apache/gobblin/pull/3702
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
TBD
### Tests
- [] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
./gradlew build
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3702: [TBD] avoid dependency from iceberg-hive-runtime which is a shaded fat jar
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3702:
URL: https://github.com/apache/gobblin/pull/3702#issuecomment-1581523204
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3702?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3702](https://app.codecov.io/gh/apache/gobblin/pull/3702?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e1f8cfd) into [master](https://app.codecov.io/gh/apache/gobblin/commit/158d6fff546ee28ad7b542bfe78e5263af8843c6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (158d6ff) will **increase** coverage by `0.03%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3702 +/- ##
============================================
+ Coverage 49.45% 49.49% +0.03%
- Complexity 9309 9316 +7
============================================
Files 1756 1756
Lines 68468 68472 +4
Branches 7809 7810 +1
============================================
+ Hits 33862 33887 +25
+ Misses 31466 31447 -19
+ Partials 3140 3138 -2
```
| [Impacted Files](https://app.codecov.io/gh/apache/gobblin/pull/3702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...paction/action/CompactionGMCEPublishingAction.java](https://app.codecov.io/gh/apache/gobblin/pull/3702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25HTUNFUHVibGlzaGluZ0FjdGlvbi5qYXZh) | `56.52% <ø> (ø)` | |
| [...org/apache/gobblin/iceberg/Utils/IcebergUtils.java](https://app.codecov.io/gh/apache/gobblin/pull/3702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvVXRpbHMvSWNlYmVyZ1V0aWxzLmphdmE=) | `65.65% <100.00%> (-0.35%)` | :arrow_down: |
| [...gobblin/iceberg/publisher/GobblinMCEPublisher.java](https://app.codecov.io/gh/apache/gobblin/pull/3702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvcHVibGlzaGVyL0dvYmJsaW5NQ0VQdWJsaXNoZXIuamF2YQ==) | `65.90% <100.00%> (-0.39%)` | :arrow_down: |
| [.../gobblin/iceberg/writer/IcebergMetadataWriter.java](https://app.codecov.io/gh/apache/gobblin/pull/3702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0ljZWJlcmdNZXRhZGF0YVdyaXRlci5qYXZh) | `72.36% <100.00%> (ø)` | |
... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/gobblin/pull/3702/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] arjun4084346 closed pull request #3702: [GOBBLIN-1839] avoid dependency from iceberg-hive-runtime which is a shaded fat jar
Posted by "arjun4084346 (via GitHub)" <gi...@apache.org>.
arjun4084346 closed pull request #3702: [GOBBLIN-1839] avoid dependency from iceberg-hive-runtime which is a shaded fat jar
URL: https://github.com/apache/gobblin/pull/3702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org