You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2016/02/09 22:38:21 UTC
Review Request 43377: Create Upgrade Packs for Patch Upgrades
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-14978
https://issues.apache.org/jira/browse/AMBARI-14978
Repository: ambari
Description
-------
Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
Diff: https://reviews.apache.org/r/43377/diff/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 9, 2016, 7:09 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml, line 68
> > <https://reviews.apache.org/r/43377/diff/1/?file=1238820#file1238820line68>
> >
> > If the patch is only for say Hive, will it still run the elements for Oozie and Ranger if they are installed?
No. If there is a requirement to do so, the Version Definition would have to indicate those services should also be upgraded. Ideally we want to get this to just an hdp-select call. For now, I just used the same-stack-upgrade packs.
> On Feb. 9, 2016, 7:09 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml, line 26
> > <https://reviews.apache.org/r/43377/diff/1/?file=1238820#file1238820line26>
> >
> > These files are nearly identical to those of RU.
> > Can we define the elements that are specific to PARTIAL so we use the existing files?
No. The point was to have the logic completely separated. If we use existing upgrade packs then we just destabilized orchestration for patches. Going the other way, changes to existing upgrade packs will then destabilize patches.
> On Feb. 9, 2016, 7:09 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, line 243
> > <https://reviews.apache.org/r/43377/diff/1/?file=1238815#file1238815line243>
> >
> > if null or empty, should raise exception.
Untrue. A repo_version without these elements is 1) backwards compatible and 2) can be a STANDARD repository instead of a PATCH one. In addition, we're checking for the existence of targeted services. If there are no targeted services, that means ALL services and regular RU/EU should be used.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118505
-----------------------------------------------------------
On Feb. 9, 2016, 6:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 6:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-14978
> https://issues.apache.org/jira/browse/AMBARI-14978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
>
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43377/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Feb. 9, 2016, 7:09 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml, line 26
> > <https://reviews.apache.org/r/43377/diff/1/?file=1238820#file1238820line26>
> >
> > These files are nearly identical to those of RU.
> > Can we define the elements that are specific to PARTIAL so we use the existing files?
>
> Nate Cole wrote:
> No. The point was to have the logic completely separated. If we use existing upgrade packs then we just destabilized orchestration for patches. Going the other way, changes to existing upgrade packs will then destabilize patches.
There are also cases where we'd need to start marking what's included and what's not included in patch upgrades as opposed to regular upgrades. Additionally, if we re-used existing packs, any changes would inadvertently affect PU as well, which can make for a very complicated testing matrix.
> On Feb. 9, 2016, 7:09 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml, line 68
> > <https://reviews.apache.org/r/43377/diff/1/?file=1238820#file1238820line68>
> >
> > If the patch is only for say Hive, will it still run the elements for Oozie and Ranger if they are installed?
>
> Nate Cole wrote:
> No. If there is a requirement to do so, the Version Definition would have to indicate those services should also be upgraded. Ideally we want to get this to just an hdp-select call. For now, I just used the same-stack-upgrade packs.
Agreed with Nate; they would need to be indicated as well.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118505
-----------------------------------------------------------
On Feb. 9, 2016, 6:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 6:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-14978
> https://issues.apache.org/jira/browse/AMBARI-14978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
>
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43377/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 9, 2016, 7:09 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, line 243
> > <https://reviews.apache.org/r/43377/diff/1/?file=1238815#file1238815line243>
> >
> > if null or empty, should raise exception.
>
> Nate Cole wrote:
> Untrue. A repo_version without these elements is 1) backwards compatible and 2) can be a STANDARD repository instead of a PATCH one. In addition, we're checking for the existence of targeted services. If there are no targeted services, that means ALL services and regular RU/EU should be used.
>
> Jonathan Hurley wrote:
> But the only way you'd get into this block is by having a PARTIAL upgrade pack, no? Doesn't that mean that you have to have an XML file?
Ok, consensus is that we change to annotate existing upgrade packs. Bring on the pain!
> On Feb. 9, 2016, 7:09 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml, line 26
> > <https://reviews.apache.org/r/43377/diff/1/?file=1238820#file1238820line26>
> >
> > These files are nearly identical to those of RU.
> > Can we define the elements that are specific to PARTIAL so we use the existing files?
>
> Nate Cole wrote:
> No. The point was to have the logic completely separated. If we use existing upgrade packs then we just destabilized orchestration for patches. Going the other way, changes to existing upgrade packs will then destabilize patches.
>
> Jonathan Hurley wrote:
> There are also cases where we'd need to start marking what's included and what's not included in patch upgrades as opposed to regular upgrades. Additionally, if we re-used existing packs, any changes would inadvertently affect PU as well, which can make for a very complicated testing matrix.
Ok, consensus is that we change to annotate existing upgrade packs. Bring on the pain!
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118505
-----------------------------------------------------------
On Feb. 9, 2016, 6:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 6:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-14978
> https://issues.apache.org/jira/browse/AMBARI-14978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
>
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43377/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Feb. 9, 2016, 7:09 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, line 243
> > <https://reviews.apache.org/r/43377/diff/1/?file=1238815#file1238815line243>
> >
> > if null or empty, should raise exception.
>
> Nate Cole wrote:
> Untrue. A repo_version without these elements is 1) backwards compatible and 2) can be a STANDARD repository instead of a PATCH one. In addition, we're checking for the existence of targeted services. If there are no targeted services, that means ALL services and regular RU/EU should be used.
But the only way you'd get into this block is by having a PARTIAL upgrade pack, no? Doesn't that mean that you have to have an XML file?
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118505
-----------------------------------------------------------
On Feb. 9, 2016, 6:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 6:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-14978
> https://issues.apache.org/jira/browse/AMBARI-14978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
>
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43377/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118505
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java (line 243)
<https://reviews.apache.org/r/43377/#comment179756>
if null or empty, should raise exception.
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml (line 26)
<https://reviews.apache.org/r/43377/#comment179757>
These files are nearly identical to those of RU.
Can we define the elements that are specific to PARTIAL so we use the existing files?
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml (line 68)
<https://reviews.apache.org/r/43377/#comment179758>
If the patch is only for say Hive, will it still run the elements for Oozie and Ranger if they are installed?
- Alejandro Fernandez
On Feb. 9, 2016, 11:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 11:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-14978
> https://issues.apache.org/jira/browse/AMBARI-14978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
>
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43377/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 10, 2016, 10:34 a.m., Jonathan Hurley wrote:
> > Looking again at this review, I really dislike that we have to include all of the patch*.xml files. However, I understand why we have them. If we ever had to change something structually, it would be a mess to try to annotate the upgrade packs.
> >
> > I just don't know which way to go on this.
Ok, consensus is that we change to annotate existing upgrade packs. Bring on the pain!
> On Feb. 10, 2016, 10:34 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, line 236
> > <https://reviews.apache.org/r/43377/diff/1/?file=1238815#file1238815line236>
> >
> > What is RepositoryType.SERVICE? I thought there were only going to be full and partial?
RepositoryType.SERVICE is not the same as UpgradeScope.PARTIAL. Both RepositoryType.PATCH and RepositoryType.SERVICE imply that you are only PARTIALly upgrading your cluster.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118663
-----------------------------------------------------------
On Feb. 9, 2016, 6:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 6:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-14978
> https://issues.apache.org/jira/browse/AMBARI-14978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
>
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43377/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118663
-----------------------------------------------------------
Looking again at this review, I really dislike that we have to include all of the patch*.xml files. However, I understand why we have them. If we ever had to change something structually, it would be a mess to try to annotate the upgrade packs.
I just don't know which way to go on this.
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java (line 236)
<https://reviews.apache.org/r/43377/#comment179956>
What is RepositoryType.SERVICE? I thought there were only going to be full and partial?
- Jonathan Hurley
On Feb. 9, 2016, 6:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 6:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-14978
> https://issues.apache.org/jira/browse/AMBARI-14978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
>
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43377/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 10, 2016, 8:37 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java, line 222
> > <https://reviews.apache.org/r/43377/diff/1/?file=1238817#file1238817line222>
> >
> > afaik, we support versionAdvertised() on component level. Could it be that not all components of some service are versionable and we need a per-component granularity?
This is only for orchestration purposes. versionAdvertised() is only used for reporting after the upgrade steps have taken place. If the component is not-advertised, there might still be work to do, we just wouldn't count it towards success.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118635
-----------------------------------------------------------
On Feb. 9, 2016, 6:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 6:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-14978
> https://issues.apache.org/jira/browse/AMBARI-14978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
>
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43377/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118635
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java (line 222)
<https://reviews.apache.org/r/43377/#comment179927>
afaik, we support versionAdvertised() on component level. Could it be that not all components of some service are versionable and we need a per-component granularity?
- Dmitro Lisnichenko
On Feb. 10, 2016, 1:01 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 1:01 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-14978
> https://issues.apache.org/jira/browse/AMBARI-14978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
>
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43377/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118734
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 10, 2016, 9:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 9:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-14978
> https://issues.apache.org/jira/browse/AMBARI-14978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
>
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java db8c079
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 05aecac
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 11e9267
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 5af893e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java e96c7ff
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java f365a7f
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 4fd3316
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 38ee39b
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ac84443
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 508483e
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 3863877
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml e45e851
> ambari-server/src/main/resources/version_definition.xsd 77b4203
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java a0ac966
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43377/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118862
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 10, 2016, 4:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 4:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-14978
> https://issues.apache.org/jira/browse/AMBARI-14978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
>
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java db8c079
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 05aecac
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 11e9267
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 5af893e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java e96c7ff
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java f365a7f
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 4fd3316
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 38ee39b
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ac84443
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 508483e
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 3863877
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml e45e851
> ambari-server/src/main/resources/version_definition.xsd 77b4203
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java a0ac966
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43377/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118825
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 10, 2016, 11:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 11:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-14978
> https://issues.apache.org/jira/browse/AMBARI-14978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
>
> Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java db8c079
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 05aecac
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 11e9267
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 5af893e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java e96c7ff
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java f365a7f
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 4fd3316
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 38ee39b
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ac84443
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 508483e
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 3863877
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml e45e851
> ambari-server/src/main/resources/version_definition.xsd 77b4203
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java a0ac966
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43377/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 4:01 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Changes
-------
Moved to annotating existing upgrade packs with scope elements. Can annotate <group>, <execute-stage> and <task> elements.
Bugs: AMBARI-14978
https://issues.apache.org/jira/browse/AMBARI-14978
Repository: ambari
Description
-------
Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java db8c079
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 05aecac
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 11e9267
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 5af893e
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java e96c7ff
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java f365a7f
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 4fd3316
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 38ee39b
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml ac84443
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 508483e
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 3863877
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml e45e851
ambari-server/src/main/resources/version_definition.xsd 77b4203
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java a0ac966
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
Diff: https://reviews.apache.org/r/43377/diff/
Testing
-------
Manual. Automated:
Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33:52.026s
[INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
[INFO] Final Memory: 33M/677M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 6:01 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-14978
https://issues.apache.org/jira/browse/AMBARI-14978
Repository: ambari
Description
-------
Created separate upgrade packs for patches. The necessitated a new enum UpgradeScope to indicate that the upgrade was for partial cluster upgrades (which will help when doing Component (Service) Upgrades).
Also added a fix for orchestration of ClusterGroupings that target specific services that are not getting upgraded.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 5e21da5
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION
Diff: https://reviews.apache.org/r/43377/diff/
Testing (updated)
-------
Manual. Automated:
Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33:52.026s
[INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
[INFO] Final Memory: 33M/677M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole