You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/22 09:41:24 UTC

[GitHub] [shardingsphere] TanveshT opened a new pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

TanveshT opened a new pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888


   Fixes #7884.
   
   Changes proposed in this pull request:
   - refactoring and import statements changed to the expected class names
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TanveshT commented on pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
TanveshT commented on pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#issuecomment-715012088


   @menghaoranss While loading the checkstyle in intellij, it's throwing this error can you help?
   ```bash
   com.puppycrawl.tools.checkstyle.api.CheckstyleException: unable to parse configuration stream - Element type "html" must be declared.:7:17
   	at com.puppycrawl.tools.checkstyle.ConfigurationLoader.loadConfiguration(ConfigurationLoader.java:322)
   	at com.puppycrawl.tools.checkstyle.ConfigurationLoader.loadConfiguration(ConfigurationLoader.java:287)
   	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   	at org.infernus.idea.checkstyle.service.cmd.OpLoadConfiguration.loadConfigurationForCheckstyle825AndAbove(OpLoadConfiguration.java:188)
   	at org.infernus.idea.checkstyle.service.cmd.OpLoadConfiguration.callLoadConfiguration(OpLoadConfiguration.java:156)
   	at org.infernus.idea.checkstyle.service.cmd.OpLoadConfiguration.execute(OpLoadConfiguration.java:139)
   	at org.infernus.idea.checkstyle.service.cmd.OpCreateChecker.loadConfig(OpCreateChecker.java:98)
   	at org.infernus.idea.checkstyle.service.cmd.OpCreateChecker.execute(OpCreateChecker.java:54)
   	at org.infernus.idea.checkstyle.service.cmd.OpCreateChecker.execute(OpCreateChecker.java:26)
   	at org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.executeCommand(CheckstyleActionsImpl.java:130)
   	at org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.createChecker(CheckstyleActionsImpl.java:60)
   	at org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.createChecker(CheckstyleActionsImpl.java:51)
   	at org.infernus.idea.checkstyle.checker.CheckerFactoryWorker.run(CheckerFactoryWorker.java:46)
   Caused by: org.xml.sax.SAXParseException; lineNumber: 7; columnNumber: 17; Element type "html" must be declared.
   	at org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown Source)
   	at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown Source)
   	at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
   	at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
   	at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
   	at org.apache.xerces.impl.dtd.XMLDTDValidator.handleStartElement(Unknown Source)
   	at org.apache.xerces.impl.dtd.XMLDTDValidator.startElement(Unknown Source)
   	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown Source)
   	at org.apache.xerces.impl.XMLDocumentScannerImpl$ContentDispatcher.scanRootElementHook(Unknown Source)
   	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source)
   	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source)
   	at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
   	at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
   	at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
   	at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
   	at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
   	at com.puppycrawl.tools.checkstyle.XmlLoader.parseInputSource(XmlLoader.java:86)
   	at com.puppycrawl.tools.checkstyle.ConfigurationLoader.parseInputSource(ConfigurationLoader.java:198)
   	at com.puppycrawl.tools.checkstyle.ConfigurationLoader.loadConfiguration(ConfigurationLoader.java:315)
   	... 15 more
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#discussion_r511700497



##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -109,11 +109,12 @@ public void watch(final String key, final DataChangedEventListener dataChangedEv
             for (WatchEvent each : response.getEvents()) {
                 ChangedType changedType = getEventChangedType(each);
                 if (ChangedType.IGNORED != changedType) {
-                    dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(Charsets.UTF_8), each.getKeyValue().getValue().toString(Charsets.UTF_8), changedType));
+                    dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(StandardCharsets.UTF_8)
+                            , each.getKeyValue().getValue().toString(StandardCharsets.UTF_8), changedType));

Review comment:
       `,` must be on the first line.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TanveshT commented on a change in pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
TanveshT commented on a change in pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#discussion_r511725362



##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -109,11 +109,12 @@ public void watch(final String key, final DataChangedEventListener dataChangedEv
             for (WatchEvent each : response.getEvents()) {
                 ChangedType changedType = getEventChangedType(each);
                 if (ChangedType.IGNORED != changedType) {
-                    dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(Charsets.UTF_8), each.getKeyValue().getValue().toString(Charsets.UTF_8), changedType));
+                    dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(StandardCharsets.UTF_8)
+                            , each.getKeyValue().getValue().toString(StandardCharsets.UTF_8), changedType));

Review comment:
       @menghaoranss first line means the same indent? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss merged pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#issuecomment-716970820


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7888?src=pr&el=h1) Report
   > Merging [#7888](https://codecov.io/gh/apache/shardingsphere/pull/7888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/dca1684798205a6efd0d94b91aa1d3f86c8baefb?el=desc) will **decrease** coverage by `0.14%`.
   > The diff coverage is `81.81%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7888/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7888?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7888      +/-   ##
   ============================================
   - Coverage     74.86%   74.72%   -0.15%     
   - Complexity      532      537       +5     
   ============================================
     Files          1431     1447      +16     
     Lines         22674    22736      +62     
     Branches       4059     4061       +2     
   ============================================
   + Hits          16976    16989      +13     
   - Misses         4603     4652      +49     
     Partials       1095     1095              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7888?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ere/governance/repository/etcd/EtcdRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/7888/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLXJlcG9zaXRvcnkvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLWdvdmVybmFuY2UtcmVwb3NpdG9yeS1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nb3Zlcm5hbmNlL3JlcG9zaXRvcnkvZXRjZC9FdGNkUmVwb3NpdG9yeS5qYXZh) | `90.69% <81.81%> (+0.22%)` | `15.00 <2.00> (ø)` | |
   | [...e/rdl/parser/engine/engine/RDLSQLParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7888/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9lbmdpbmUvZW5naW5lL1JETFNRTFBhcnNlckVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...l/parser/engine/ShardingSphereSQLParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7888/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9lbmdpbmUvU2hhcmRpbmdTcGhlcmVTUUxQYXJzZXJFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...pository/zookeeper/CuratorZookeeperRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/7888/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLXJlcG9zaXRvcnkvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLWdvdmVybmFuY2UtcmVwb3NpdG9yeS16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZ292ZXJuYW5jZS9yZXBvc2l0b3J5L3pvb2tlZXBlci9DdXJhdG9yWm9va2VlcGVyUmVwb3NpdG9yeS5qYXZh) | `73.72% <0.00%> (ø)` | `26.00% <0.00%> (ø%)` | |
   | [...isitor/statement/SQLServerStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7888/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWxzZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3Fsc2VydmVyL3Zpc2l0b3Ivc3RhdGVtZW50L1NRTFNlcnZlclN0YXRlbWVudFNRTFZpc2l0b3IuamF2YQ==) | | | |
   | [...er/visitor/SQLServerStatementSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/7888/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWxzZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3Fsc2VydmVyL3Zpc2l0b3IvU1FMU2VydmVyU3RhdGVtZW50U1FMVmlzaXRvckZhY2FkZS5qYXZh) | | | |
   | [...ne/statement/standard/StandardSQLParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7888/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9lbmdpbmUvc3RhdGVtZW50L3N0YW5kYXJkL1N0YW5kYXJkU1FMUGFyc2VyRW5naW5lLmphdmE=) | | | |
   | [...ql/visitor/statement/MySQLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7888/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9NeVNRTFN0YXRlbWVudFNRTFZpc2l0b3IuamF2YQ==) | | | |
   | [...here/sql/parser/engine/ast/ASTSQLParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7888/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9lbmdpbmUvYXN0L0FTVFNRTFBhcnNlckVuZ2luZS5qYXZh) | | | |
   | [...racle/visitor/OracleStatementSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/7888/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3IvT3JhY2xlU3RhdGVtZW50U1FMVmlzaXRvckZhY2FkZS5qYXZh) | | | |
   | ... and [46 more](https://codecov.io/gh/apache/shardingsphere/pull/7888/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7888?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7888?src=pr&el=footer). Last update [dca1684...81df345](https://codecov.io/gh/apache/shardingsphere/pull/7888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TanveshT commented on pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
TanveshT commented on pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#issuecomment-714900676


   Hey I'll first install check style on my local system and then commit asap


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#discussion_r512378621



##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -109,11 +109,12 @@ public void watch(final String key, final DataChangedEventListener dataChangedEv
             for (WatchEvent each : response.getEvents()) {
                 ChangedType changedType = getEventChangedType(each);
                 if (ChangedType.IGNORED != changedType) {
-                    dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(Charsets.UTF_8), each.getKeyValue().getValue().toString(Charsets.UTF_8), changedType));
+                    dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(StandardCharsets.UTF_8)
+                            , each.getKeyValue().getValue().toString(StandardCharsets.UTF_8), changedType));

Review comment:
       @TanveshT Hi, any other questions?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TanveshT commented on pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
TanveshT commented on pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#issuecomment-714390595


   @menghaoranss Okay I will fix it asap
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#issuecomment-714397685


   > @menghaoranss Okay I will fix it asap
   > I wanted to ask that what is the checkstyle constraints? like if I just move a .function to the next line will it trigger some other checkstyle warning?
   
   `,` must be on the first line.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#discussion_r511759682



##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -109,11 +109,12 @@ public void watch(final String key, final DataChangedEventListener dataChangedEv
             for (WatchEvent each : response.getEvents()) {
                 ChangedType changedType = getEventChangedType(each);
                 if (ChangedType.IGNORED != changedType) {
-                    dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(Charsets.UTF_8), each.getKeyValue().getValue().toString(Charsets.UTF_8), changedType));
+                    dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(StandardCharsets.UTF_8)
+                            , each.getKeyValue().getValue().toString(StandardCharsets.UTF_8), changedType));

Review comment:
       ```
   dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(StandardCharsets.UTF_8),
                               each.getKeyValue().getValue().toString(StandardCharsets.UTF_8), changedType));
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#issuecomment-714868210


   @TanveshT any problems?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TanveshT commented on a change in pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
TanveshT commented on a change in pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#discussion_r512383167



##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -109,11 +109,12 @@ public void watch(final String key, final DataChangedEventListener dataChangedEv
             for (WatchEvent each : response.getEvents()) {
                 ChangedType changedType = getEventChangedType(each);
                 if (ChangedType.IGNORED != changedType) {
-                    dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(Charsets.UTF_8), each.getKeyValue().getValue().toString(Charsets.UTF_8), changedType));
+                    dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(StandardCharsets.UTF_8)
+                            , each.getKeyValue().getValue().toString(StandardCharsets.UTF_8), changedType));

Review comment:
       Nothing else @menghaoranss. Will make the that commit soon
   

##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -109,11 +109,12 @@ public void watch(final String key, final DataChangedEventListener dataChangedEv
             for (WatchEvent each : response.getEvents()) {
                 ChangedType changedType = getEventChangedType(each);
                 if (ChangedType.IGNORED != changedType) {
-                    dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(Charsets.UTF_8), each.getKeyValue().getValue().toString(Charsets.UTF_8), changedType));
+                    dataChangedEventListener.onChange(new DataChangedEvent(each.getKeyValue().getKey().toString(StandardCharsets.UTF_8)
+                            , each.getKeyValue().getValue().toString(StandardCharsets.UTF_8), changedType));

Review comment:
       Nothing else @menghaoranss. Will make that commit soon
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#issuecomment-714921964


   > Hey I'll first install check style on my local system and then commit asap
   
   Okay, this is the checkstyle rule for shardingsphere :
   `https://github.com/apache/shardingsphere/blob/master/src/resources/checkstyle.xml`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking edited a comment on pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
kimmking edited a comment on pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#issuecomment-715271009


   @TanveshT  this xml file is used by maven, not IDEA.
   `mvn clean install` in the repo root and it works.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking commented on pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
kimmking commented on pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#issuecomment-715271009


   @TanveshT  this xml file is used by maven, not IDEA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#issuecomment-714389780


   @TanveshT thanks for your pr, please fix the checkstyle error:
   ```
   Error:  src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java:[112] (sizes) LineLength: Line is longer than 200 characters (found 215).
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TanveshT edited a comment on pull request #7888: refractored Charsets to StandardCharsets Fixes #7884

Posted by GitBox <gi...@apache.org>.
TanveshT edited a comment on pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#issuecomment-714390595


   @menghaoranss Okay I will fix it asap
   I wanted to ask that what is the checkstyle constraints? like if I just move a .function to the next line will it trigger some other checkstyle warning?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org