You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@struts.apache.org by lu...@apache.org on 2022/11/04 08:03:59 UTC
[struts] branch WW-4514-url updated (728edbef5 -> bfcc0b589)
This is an automated email from the ASF dual-hosted git repository.
lukaszlenart pushed a change to branch WW-4514-url
in repository https://gitbox.apache.org/repos/asf/struts.git
from 728edbef5 Increases sleep to avoid false test failures
new 4a51aacf4 WW-4514 Avoids logging user provided data
new bfcc0b589 Swaps expected with actual
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../main/java/org/apache/struts2/url/StrutsParametersStringBuilder.java | 2 +-
core/src/test/java/org/apache/struts2/url/StrutsUrlDecoderTest.java | 2 +-
core/src/test/java/org/apache/struts2/url/StrutsUrlEncoderTest.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
[struts] 02/02: Swaps expected with actual
Posted by lu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lukaszlenart pushed a commit to branch WW-4514-url
in repository https://gitbox.apache.org/repos/asf/struts.git
commit bfcc0b589837462041ffc9729f29181089fc4d71
Author: Lukasz Lenart <lu...@apache.org>
AuthorDate: Fri Nov 4 09:03:54 2022 +0100
Swaps expected with actual
---
core/src/test/java/org/apache/struts2/url/StrutsUrlDecoderTest.java | 2 +-
core/src/test/java/org/apache/struts2/url/StrutsUrlEncoderTest.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/core/src/test/java/org/apache/struts2/url/StrutsUrlDecoderTest.java b/core/src/test/java/org/apache/struts2/url/StrutsUrlDecoderTest.java
index fe70d0944..cd52ba75b 100644
--- a/core/src/test/java/org/apache/struts2/url/StrutsUrlDecoderTest.java
+++ b/core/src/test/java/org/apache/struts2/url/StrutsUrlDecoderTest.java
@@ -110,7 +110,7 @@ public class StrutsUrlDecoderTest {
public void testDecoding() {
String result = decoder.decode("%E6%96%B0%E8%81%9E");
- assertEquals(result, "\u65b0\u805e");
+ assertEquals("\u65b0\u805e", result);
}
@Before
diff --git a/core/src/test/java/org/apache/struts2/url/StrutsUrlEncoderTest.java b/core/src/test/java/org/apache/struts2/url/StrutsUrlEncoderTest.java
index 361d44133..87b5bcce9 100644
--- a/core/src/test/java/org/apache/struts2/url/StrutsUrlEncoderTest.java
+++ b/core/src/test/java/org/apache/struts2/url/StrutsUrlEncoderTest.java
@@ -86,7 +86,7 @@ public class StrutsUrlEncoderTest {
public void testEncoding() {
String result = encoder.encode("\u65b0\u805e");
- assertEquals(result, "%E6%96%B0%E8%81%9E");
+ assertEquals("%E6%96%B0%E8%81%9E", result);
}
@Before
[struts] 01/02: WW-4514 Avoids logging user provided data
Posted by lu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lukaszlenart pushed a commit to branch WW-4514-url
in repository https://gitbox.apache.org/repos/asf/struts.git
commit 4a51aacf406bdb81a3d1c0ae975c8e47c298bdc2
Author: Lukasz Lenart <lu...@apache.org>
AuthorDate: Fri Nov 4 09:02:46 2022 +0100
WW-4514 Avoids logging user provided data
---
.../main/java/org/apache/struts2/url/StrutsParametersStringBuilder.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/core/src/main/java/org/apache/struts2/url/StrutsParametersStringBuilder.java b/core/src/main/java/org/apache/struts2/url/StrutsParametersStringBuilder.java
index 7b13fa310..e6e38f451 100644
--- a/core/src/main/java/org/apache/struts2/url/StrutsParametersStringBuilder.java
+++ b/core/src/main/java/org/apache/struts2/url/StrutsParametersStringBuilder.java
@@ -38,7 +38,7 @@ public class StrutsParametersStringBuilder implements ParametersStringBuilder {
@Override
public void buildParametersString(Map<String, Object> params, StringBuilder link, String paramSeparator) {
if ((params != null) && (params.size() > 0)) {
- LOG.debug("Building query string out of: {}", params);
+ LOG.debug("Building query string out of: {} parameters", params.size());
StringBuilder queryString = new StringBuilder();
// Set params