You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by shivzone <gi...@git.apache.org> on 2017/02/10 19:27:11 UTC
[GitHub] incubator-hawq pull request #1114: HAWQ-1320. Remove reference to PXF rpm ve...
GitHub user shivzone opened a pull request:
https://github.com/apache/incubator-hawq/pull/1114
HAWQ-1320. Remove reference to PXF rpm version in source
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shivzone/incubator-hawq HAWQ-1320
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1114
----
commit 7a3def8e7e3cfed2af93cff178469f886a7a56f2
Author: shivzone <sh...@gmail.com>
Date: 2017-02-10T19:26:01Z
HAWQ-1320. Remove reference to PXF rpm version in source
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1114: HAWQ-1320. Remove reference to PXF rpm ve...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1114#discussion_r100632037
--- Diff: pxf/Makefile ---
@@ -38,6 +38,10 @@ ifneq "$(VENDOR)" ""
BUILD_PARAMS+= -Pvendor="$(VENDOR)"
endif
+ifneq "$(PXF_VERSION)" ""
--- End diff --
Not really. We should still be able to run simple dev builds which don't require PXF version
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1114: HAWQ-1320. Remove reference to PXF rpm ve...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1114#discussion_r100616374
--- Diff: pxf/Makefile ---
@@ -38,6 +38,10 @@ ifneq "$(VENDOR)" ""
BUILD_PARAMS+= -Pvendor="$(VENDOR)"
endif
+ifneq "$(PXF_VERSION)" ""
+ BUILD_PARAMSi+= -Pversion="$(PXF_VERSION)"
--- End diff --
good catch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1114: HAWQ-1320. Remove reference to PXF rpm ve...
Posted by ljainpivotalio <gi...@git.apache.org>.
Github user ljainpivotalio commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1114#discussion_r100613055
--- Diff: pxf/Makefile ---
@@ -38,6 +38,10 @@ ifneq "$(VENDOR)" ""
BUILD_PARAMS+= -Pvendor="$(VENDOR)"
endif
+ifneq "$(PXF_VERSION)" ""
+ BUILD_PARAMSi+= -Pversion="$(PXF_VERSION)"
--- End diff --
There is an extra i after BUILD_PARAMS.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1114: HAWQ-1320. Remove reference to PXF rpm ve...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1114#discussion_r100628050
--- Diff: pxf/Makefile ---
@@ -38,6 +38,10 @@ ifneq "$(VENDOR)" ""
BUILD_PARAMS+= -Pvendor="$(VENDOR)"
endif
+ifneq "$(PXF_VERSION)" ""
--- End diff --
Shouldn't we fail if there is no value for PXF_VERSION available?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1114: HAWQ-1320. Remove reference to PXF rpm version i...
Posted by ljainpivotalio <gi...@git.apache.org>.
Github user ljainpivotalio commented on the issue:
https://github.com/apache/incubator-hawq/pull/1114
Please feel free to merge when done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1114: HAWQ-1320. Remove reference to PXF rpm ve...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---