You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Mike Percy (Created) (JIRA)" <ji...@apache.org> on 2012/03/16 23:14:40 UTC
[jira] [Created] (FLUME-1035) slf4j error in flume sdk unit tests
slf4j error in flume sdk unit tests
-----------------------------------
Key: FLUME-1035
URL: https://issues.apache.org/jira/browse/FLUME-1035
Project: Flume
Issue Type: Bug
Affects Versions: v1.1.0, v1.2.0
Reporter: Mike Percy
Assignee: Mike Percy
Fix For: v1.1.0, v1.2.0
There is a problem in the SDK unit tests with slf4j where the SDK does not include an implementation of SLF4J in the classpath while it uses JUL for logging.
We should make it consistent by using SLF4J and also provide an implementation (Log4j) in the classpath for the SDK unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1035) slf4j error in flume sdk unit tests
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232918#comment-13232918 ]
Hudson commented on FLUME-1035:
-------------------------------
Integrated in flume-trunk #132 (See [https://builds.apache.org/job/flume-trunk/132/])
FLUME-1035: slf4j error in flume sdk unit tests
(Mike Percy via Brock Noland) (Revision 1302638)
Result = SUCCESS
brock : http://svn.apache.org/viewvc/?view=rev&rev=1302638
Files :
* /incubator/flume/trunk/flume-ng-sdk/pom.xml
* /incubator/flume/trunk/flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java
* /incubator/flume/trunk/flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java
> slf4j error in flume sdk unit tests
> -----------------------------------
>
> Key: FLUME-1035
> URL: https://issues.apache.org/jira/browse/FLUME-1035
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0, v1.2.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1035-2.patch
>
>
> There is a problem in the SDK unit tests with slf4j where the SDK does not include an implementation of SLF4J in the classpath while it uses JUL for logging.
> We should make it consistent by using SLF4J and also provide an implementation (Log4j) in the classpath for the SDK unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1035) slf4j error in flume sdk unit tests
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232809#comment-13232809 ]
jiraposter@reviews.apache.org commented on FLUME-1035:
------------------------------------------------------
bq. On 2012-03-17 13:33:38, Brock Noland wrote:
bq. > Attach the patch to the JIRA and I will see if my commit privileges are working.
Done. Thanks Brock!
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4392/#review6063
-----------------------------------------------------------
On 2012-03-17 02:03:05, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4392/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-17 02:03:05)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch fixes issues with unit test logging in the SDK.
bq.
bq.
bq. This addresses bug FLUME-1035.
bq. https://issues.apache.org/jira/browse/FLUME-1035
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION
bq. flume-ng-sdk/pom.xml d1c6adf
bq. flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d
bq. flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4
bq.
bq. Diff: https://reviews.apache.org/r/4392/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> slf4j error in flume sdk unit tests
> -----------------------------------
>
> Key: FLUME-1035
> URL: https://issues.apache.org/jira/browse/FLUME-1035
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0, v1.2.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1035-2.patch
>
>
> There is a problem in the SDK unit tests with slf4j where the SDK does not include an implementation of SLF4J in the classpath while it uses JUL for logging.
> We should make it consistent by using SLF4J and also provide an implementation (Log4j) in the classpath for the SDK unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1035) slf4j error in flume sdk unit tests
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231800#comment-13231800 ]
jiraposter@reviews.apache.org commented on FLUME-1035:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4392/
-----------------------------------------------------------
(Updated 2012-03-17 02:03:05.530063)
Review request for Flume.
Changes
-------
There is a weird issue with Maven (bug?) where if one of my dependencies has a dependency set to "test", the distribution will not include it if I have the same dependency set to "compile". For the moment, the workaround is to specify slf4j-api as a dependency, along with slf4j-log4j12, even though they are only used in the tests.
Summary
-------
This patch fixes issues with unit test logging in the SDK.
This addresses bug FLUME-1035.
https://issues.apache.org/jira/browse/FLUME-1035
Diffs (updated)
-----
flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION
flume-ng-sdk/pom.xml d1c6adf
flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d
flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4
Diff: https://reviews.apache.org/r/4392/diff
Testing
-------
Thanks,
Mike
> slf4j error in flume sdk unit tests
> -----------------------------------
>
> Key: FLUME-1035
> URL: https://issues.apache.org/jira/browse/FLUME-1035
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0, v1.2.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.1.0, v1.2.0
>
>
> There is a problem in the SDK unit tests with slf4j where the SDK does not include an implementation of SLF4J in the classpath while it uses JUL for logging.
> We should make it consistent by using SLF4J and also provide an implementation (Log4j) in the classpath for the SDK unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1035) slf4j error in flume sdk unit tests
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-1035:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed in 1302638. Thank you Mike for your contribution!
> slf4j error in flume sdk unit tests
> -----------------------------------
>
> Key: FLUME-1035
> URL: https://issues.apache.org/jira/browse/FLUME-1035
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0, v1.2.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1035-2.patch
>
>
> There is a problem in the SDK unit tests with slf4j where the SDK does not include an implementation of SLF4J in the classpath while it uses JUL for logging.
> We should make it consistent by using SLF4J and also provide an implementation (Log4j) in the classpath for the SDK unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1035) slf4j error in flume sdk unit tests
Posted by "Mike Percy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1035:
------------------------------
Status: Patch Available (was: Open)
> slf4j error in flume sdk unit tests
> -----------------------------------
>
> Key: FLUME-1035
> URL: https://issues.apache.org/jira/browse/FLUME-1035
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0, v1.2.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1035-2.patch
>
>
> There is a problem in the SDK unit tests with slf4j where the SDK does not include an implementation of SLF4J in the classpath while it uses JUL for logging.
> We should make it consistent by using SLF4J and also provide an implementation (Log4j) in the classpath for the SDK unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1035) slf4j error in flume sdk unit tests
Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-1035:
------------------------------------
Fix Version/s: (was: v1.1.0)
> slf4j error in flume sdk unit tests
> -----------------------------------
>
> Key: FLUME-1035
> URL: https://issues.apache.org/jira/browse/FLUME-1035
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0, v1.2.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
>
> There is a problem in the SDK unit tests with slf4j where the SDK does not include an implementation of SLF4J in the classpath while it uses JUL for logging.
> We should make it consistent by using SLF4J and also provide an implementation (Log4j) in the classpath for the SDK unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1035) slf4j error in flume sdk unit tests
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231965#comment-13231965 ]
jiraposter@reviews.apache.org commented on FLUME-1035:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4392/#review6063
-----------------------------------------------------------
Ship it!
Attach the patch to the JIRA and I will see if my commit privileges are working.
- Brock
On 2012-03-17 02:03:05, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4392/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-17 02:03:05)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch fixes issues with unit test logging in the SDK.
bq.
bq.
bq. This addresses bug FLUME-1035.
bq. https://issues.apache.org/jira/browse/FLUME-1035
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION
bq. flume-ng-sdk/pom.xml d1c6adf
bq. flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d
bq. flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4
bq.
bq. Diff: https://reviews.apache.org/r/4392/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> slf4j error in flume sdk unit tests
> -----------------------------------
>
> Key: FLUME-1035
> URL: https://issues.apache.org/jira/browse/FLUME-1035
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0, v1.2.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.1.0, v1.2.0
>
>
> There is a problem in the SDK unit tests with slf4j where the SDK does not include an implementation of SLF4J in the classpath while it uses JUL for logging.
> We should make it consistent by using SLF4J and also provide an implementation (Log4j) in the classpath for the SDK unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1035) slf4j error in flume sdk unit tests
Posted by "Mike Percy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1035:
------------------------------
Attachment: FLUME-1035-2.patch
> slf4j error in flume sdk unit tests
> -----------------------------------
>
> Key: FLUME-1035
> URL: https://issues.apache.org/jira/browse/FLUME-1035
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0, v1.2.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1035-2.patch
>
>
> There is a problem in the SDK unit tests with slf4j where the SDK does not include an implementation of SLF4J in the classpath while it uses JUL for logging.
> We should make it consistent by using SLF4J and also provide an implementation (Log4j) in the classpath for the SDK unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1035) slf4j error in flume sdk unit tests
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231681#comment-13231681 ]
jiraposter@reviews.apache.org commented on FLUME-1035:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4392/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
This patch fixes issues with unit test logging in the SDK.
This addresses bug FLUME-1035.
https://issues.apache.org/jira/browse/FLUME-1035
Diffs
-----
flume-ng-sdk/pom.xml d1c6adf
flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d
flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4
flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION
Diff: https://reviews.apache.org/r/4392/diff
Testing
-------
Thanks,
Mike
> slf4j error in flume sdk unit tests
> -----------------------------------
>
> Key: FLUME-1035
> URL: https://issues.apache.org/jira/browse/FLUME-1035
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0, v1.2.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.1.0, v1.2.0
>
>
> There is a problem in the SDK unit tests with slf4j where the SDK does not include an implementation of SLF4J in the classpath while it uses JUL for logging.
> We should make it consistent by using SLF4J and also provide an implementation (Log4j) in the classpath for the SDK unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira