You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/01/12 02:20:39 UTC

Re: Review Request 62965: Added doc for cgroups devices isolator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/
-----------------------------------------------------------

(Updated Jan. 12, 2018, 2:20 a.m.)


Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.


Changes
-------

Addressed comments.


Repository: mesos


Description
-------

Added doc for cgroups devices isolator.


Diffs (updated)
-----

  docs/isolators/cgroups-devices.md PRE-CREATION 
  docs/mesos-containerizer.md 28d5ccd1fb760485a92ec532c301958224e39526 


Diff: https://reviews.apache.org/r/62965/diff/3/

Changes: https://reviews.apache.org/r/62965/diff/2-3/


Testing
-------

https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md


Thanks,

Jie Yu

Re: Review Request 62965: Added doc for cgroups devices isolator.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/#review195335
-----------------------------------------------------------



PASS: Mesos patch 62965 was successfully built and tested.

Reviews applied: `['62965']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62965

- Mesos Reviewbot Windows


On Jan. 12, 2018, 4:24 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62965/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2018, 4:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added doc for cgroups devices isolator.
> 
> 
> Diffs
> -----
> 
>   docs/isolators/cgroups-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 28d5ccd1fb760485a92ec532c301958224e39526 
> 
> 
> Diff: https://reviews.apache.org/r/62965/diff/4/
> 
> 
> Testing
> -------
> 
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62965: Added doc for cgroups devices isolator.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/#review195355
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Jan. 12, 2018, 8:24 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62965/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2018, 8:24 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added doc for cgroups devices isolator.
> 
> 
> Diffs
> -----
> 
>   docs/isolators/cgroups-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 28d5ccd1fb760485a92ec532c301958224e39526 
> 
> 
> Diff: https://reviews.apache.org/r/62965/diff/4/
> 
> 
> Testing
> -------
> 
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62965: Added doc for cgroups devices isolator.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/
-----------------------------------------------------------

(Updated Jan. 12, 2018, 4:24 p.m.)


Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.


Repository: mesos


Description
-------

Added doc for cgroups devices isolator.


Diffs (updated)
-----

  docs/isolators/cgroups-devices.md PRE-CREATION 
  docs/mesos-containerizer.md 28d5ccd1fb760485a92ec532c301958224e39526 


Diff: https://reviews.apache.org/r/62965/diff/4/

Changes: https://reviews.apache.org/r/62965/diff/3-4/


Testing
-------

https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md


Thanks,

Jie Yu

Re: Review Request 62965: Added doc for cgroups devices isolator.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/#review195292
-----------------------------------------------------------



PASS: Mesos patch 62965 was successfully built and tested.

Reviews applied: `['62965']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62965

- Mesos Reviewbot Windows


On Jan. 12, 2018, 2:20 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62965/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2018, 2:20 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added doc for cgroups devices isolator.
> 
> 
> Diffs
> -----
> 
>   docs/isolators/cgroups-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 28d5ccd1fb760485a92ec532c301958224e39526 
> 
> 
> Diff: https://reviews.apache.org/r/62965/diff/3/
> 
> 
> Testing
> -------
> 
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>