You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/11/20 23:11:34 UTC

Review Request 40563: Added functionality for handling status updates from HTTP based executors

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40563/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Bugs: MESOS-3476
    https://issues.apache.org/jira/browse/MESOS-3476


Repository: mesos


Description
-------

This change adds the ability for the agent to handle status updates from HTTP based executors. Previously, the existing `statusUpdate` method used to handle status updates sent from slave with `pid == UPID()`, sent from other executors/on behalf of other executors with `pid == Some()`. This change modifies the argument to be `Option<PID>`. This ensures that `pid == None()` when set, the ACK is correctly routed to the corresponding HTTP based executor.


Diffs
-----

  src/slave/http.cpp ce48a0584ab18a8d95dd02619f62df18b2276639 
  src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
  src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 

Diff: https://reviews.apache.org/r/40563/diff/


Testing
-------

make check + would add tests once the https://reviews.apache.org/r/39297/ chain is reviewed.


Thanks,

Anand Mazumdar