You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/01/05 11:18:21 UTC
[GitHub] [fineract] BLasan opened a new pull request #1563: Fix granting privileges to MySQL root-user (FINERACT-1284)
BLasan opened a new pull request #1563:
URL: https://github.com/apache/fineract/pull/1563
## Description
Fixed privileges granting query.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1563: Fix granting privileges to MySQL root-user (FINERACT-1284)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1563:
URL: https://github.com/apache/fineract/pull/1563#issuecomment-757476972
@BLasan thanks for making a first time contribution to Fineract! FYI the build here failed due to FINERACT-887, please watch that issue, and then rebase this PR once that's solved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1563: Fix granting privileges to MySQL root-user (FINERACT-1284)
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1563:
URL: https://github.com/apache/fineract/pull/1563#issuecomment-757480473
> @BLasan thanks for making a first time contribution to Fineract! FYI the build here failed due to [FINERACT-887](https://issues.apache.org/jira/browse/FINERACT-887), please watch that issue, and then rebase this PR once that's solved.
will solve it sir :) @vorburger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan closed pull request #1563: Fix granting privileges to MySQL root-user (FINERACT-1284)
Posted by GitBox <gi...@apache.org>.
BLasan closed pull request #1563:
URL: https://github.com/apache/fineract/pull/1563
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1563: Fix granting privileges to MySQL root-user (FINERACT-1284)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1563:
URL: https://github.com/apache/fineract/pull/1563#issuecomment-761792877
@BLasan the "culture" (here and in open source in general) is that YOU and not "we" (me) would close anything that you opened... :-) if you "retract" a proposed change. Will you close this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1563: Fix granting privileges to MySQL root-user (FINERACT-1284)
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1563:
URL: https://github.com/apache/fineract/pull/1563#issuecomment-754715647
@awasum Travis build fails
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan edited a comment on pull request #1563: Fix granting privileges to MySQL root-user (FINERACT-1284)
Posted by GitBox <gi...@apache.org>.
BLasan edited a comment on pull request #1563:
URL: https://github.com/apache/fineract/pull/1563#issuecomment-757480473
> @BLasan thanks for making a first time contribution to Fineract! FYI the build here failed due to [FINERACT-887](https://issues.apache.org/jira/browse/FINERACT-887), please watch that issue, and then rebase this PR once that's solved.
will resolve it sir :) @vorburger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan removed a comment on pull request #1563: Fix granting privileges to MySQL root-user (FINERACT-1284)
Posted by GitBox <gi...@apache.org>.
BLasan removed a comment on pull request #1563:
URL: https://github.com/apache/fineract/pull/1563#issuecomment-757480473
> @BLasan thanks for making a first time contribution to Fineract! FYI the build here failed due to [FINERACT-887](https://issues.apache.org/jira/browse/FINERACT-887), please watch that issue, and then rebase this PR once that's solved.
will resolve it sir :) @vorburger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1563: Fix granting privileges to MySQL root-user (FINERACT-1284)
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1563:
URL: https://github.com/apache/fineract/pull/1563#issuecomment-761794301
> @BLasan the "culture" (here and in open source in general) is that YOU and not "we" (me) would close anything that you opened... :-) if you "retract" a proposed change. Will you close this PR?
Ok sir, I'll close this :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1563: Fix granting privileges to MySQL root-user (FINERACT-1284)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1563:
URL: https://github.com/apache/fineract/pull/1563#issuecomment-761784418
@BLasan if you still want this, you can rebase it and the build should now pass. Do read my comment in FINERACT-1284 as well though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1563: Fix granting privileges to MySQL root-user (FINERACT-1284)
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1563:
URL: https://github.com/apache/fineract/pull/1563#issuecomment-761790045
> @BLasan if you still want this, you can rebase it and the build should now pass. Do read my comment in [FINERACT-1284](https://issues.apache.org/jira/browse/FINERACT-1284) as well though.
I think we could close this PR :) See my comment [FINERACT-1284](https://issues.apache.org/jira/browse/FINERACT-1284)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1563: Fix granting privileges to MySQL root-user (FINERACT-1284)
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1563:
URL: https://github.com/apache/fineract/pull/1563#issuecomment-755280222
@vorburger please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org