You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/09/19 09:41:44 UTC
[GitHub] zeppelin pull request #1437: ZEPPELIN-1454: Wrong property value on interpre...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/1437
ZEPPELIN-1454: Wrong property value on interpreter page
### What is this PR for?
If for some reason (for example permission issue in file system) while saving interpreter setting, UI shows wrong value till the next restart.
IMO interpreter.json should be the source of truth, that should always be reflected on UI
### What type of PR is it?
[Bug Fix]
### Todos
* [x] - read from file-system after saving
### What is the Jira issue?
* [ZEPPELIN-1454](https://issues.apache.org/jira/browse/ZEPPELIN-1454)
### How should this be tested?
Change file system permission of "interpreter.json", and make it readonly, then on interpreter setting page try and change any property and refresh the page, refer screenshot
### Screenshots (if appropriate)
Before
After
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1454
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1437.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1437
----
commit f94125c17947d0e9387f94501a0d3ec70f983723
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2016-09-19T09:35:11Z
ZEPPELIN-1454: read from file-system after saving
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1437: ZEPPELIN-1454: Wrong property value on interpreter pag...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1437
Will merge this in both master and 0.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1437: ZEPPELIN-1454: Wrong property value on interpreter pag...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1437
@randerzander can you explain a bit more, how do you think this is related. As scope of this PR is only limited to interpreter property being saved (or fail to save) on file system.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1437: ZEPPELIN-1454: Wrong property value on interpreter pag...
Posted by randerzander <gi...@git.apache.org>.
Github user randerzander commented on the issue:
https://github.com/apache/zeppelin/pull/1437
I believe the test failure is unrelated.
However, before merging this and implying support for the thin client, I ran into another issue with mangled JDBC properties in the URL: https://issues.apache.org/jira/browse/ZEPPELIN-1459
I think ZEPPELIN-1459 should be resolved before merging this doc update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1437: ZEPPELIN-1454: Wrong property value on interpre...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1437
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1437: ZEPPELIN-1454: Wrong property value on interpre...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/1437
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1437: ZEPPELIN-1454: Wrong property value on interpre...
Posted by prabhjyotsingh <gi...@git.apache.org>.
GitHub user prabhjyotsingh reopened a pull request:
https://github.com/apache/zeppelin/pull/1437
ZEPPELIN-1454: Wrong property value on interpreter page
### What is this PR for?
If for some reason (for example permission issue in file system) while saving interpreter setting, UI shows wrong value till the next restart.
IMO interpreter.json should be the source of truth, that should always be reflected on UI
### What type of PR is it?
[Bug Fix]
### Todos
* [x] - read from file-system after saving
### What is the Jira issue?
* [ZEPPELIN-1454](https://issues.apache.org/jira/browse/ZEPPELIN-1454)
### How should this be tested?
Change file system permission of "interpreter.json", and make it readonly, then on interpreter setting page try and change any property and refresh the page, refer screenshot
### Screenshots (if appropriate)
Before
After
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1454
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1437.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1437
----
commit f94125c17947d0e9387f94501a0d3ec70f983723
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2016-09-19T09:35:11Z
ZEPPELIN-1454: read from file-system after saving
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---