[GitHub] [incubator-kyuubi] jiaoqingbo commented on pull request #2206: [KYUUBI #2203][FLINK] Support flink conf set by kyuubi conf file

[GitBox <gi...@apache.org>]

jiaoqingbo commented on pull request #2206:
URL: https://github.com/apache/incubator-kyuubi/pull/2206#issuecomment-1077262657


   > 
   
   
   > If I understand correctly, the behavior of engine-specific properties defined in `kyuubi-default.conf` is different in Spark and Flink. For Spark, we can define the properties as-is, e.g. define `spark.driver.memory` in `kyuubi-default.conf` has a same effect with defining `spark.driver.memory` in `spark-defaults.conf`, but for Flink, user need to add a prefix `flink` in `kyuubi-defaults.conf`, e.g. define `flink.jobmanager.memory.heap.size` in `kyuubi-default.conf` has a same effect with defining `jobmanager.memory.heap.size` in `flink-conf.yaml`.
   > 
   > I'm fine with prefix design, but we need to document such behavior clearly otherwise users may confusing when they use both Spark and Flink engines.
   
   It's better to define a specific prefix for each engine and add it to the DOC, and take into account that we may add new engine support


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org