[GitHub] [spark] xkrogen commented on a diff in pull request #36264: [SPARK-38950][SQL] Return Array of Predicate for SupportsPushDownCatalystFilters.pushedFilters

[GitBox <gi...@apache.org>]

xkrogen commented on code in PR #36264:
URL: https://github.com/apache/spark/pull/36264#discussion_r855348828


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/connector/SupportsPushDownCatalystFilters.scala:
##########
@@ -35,7 +35,7 @@ trait SupportsPushDownCatalystFilters {
 
   /**
    * Returns the data filters that are pushed to the data source via
-   * {@link #pushFilters(Expression[])}.
+   * {@link #pushFilters(Predicate[])}.

Review Comment:
   This change was wrong, wasn't it? `pushFilters` still takes a `Seq[Expression]`, not a `Predicate[]`. Seems it was wrong even before, since the parameter is a `Seq`, not an array.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org