You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2016/11/15 19:28:59 UTC

svn commit: r1769870 - in /directory/apacheds/trunk: core-api/src/main/java/org/apache/directory/server/core/api/ core-api/src/main/java/org/apache/directory/server/core/api/authn/ppolicy/ core-api/src/main/java/org/apache/directory/server/core/api/cha...

Author: elecharny
Date: Tue Nov 15 19:28:59 2016
New Revision: 1769870

URL: http://svn.apache.org/viewvc?rev=1769870&view=rev
Log:
o Fixed Checkstyle errors

Modified:
    directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/InterceptorEnum.java
    directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/OperationEnum.java
    directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/ReferralHandlingMode.java
    directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/authn/ppolicy/CheckQualityEnum.java
    directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/changelog/RevisionOrder.java
    directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/event/EventType.java
    directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/interceptor/context/BindOperationContext.java
    directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/sp/StoredProcEngine.java
    directory/apacheds/trunk/core-avl/src/main/java/org/apache/directory/server/core/avltree/avl/AvlNode.java
    directory/apacheds/trunk/core-avl/src/main/java/org/apache/directory/server/core/avltree/avl/AvlTreeIterator.java
    directory/apacheds/trunk/core-shared/src/main/java/org/apache/directory/server/core/shared/SortedEntryComparator.java

Modified: directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/InterceptorEnum.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/InterceptorEnum.java?rev=1769870&r1=1769869&r2=1769870&view=diff
==============================================================================
--- directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/InterceptorEnum.java (original)
+++ directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/InterceptorEnum.java Tue Nov 15 19:28:59 2016
@@ -51,7 +51,7 @@ public enum InterceptorEnum
      * The private constructor
      * @param methodName The associated interceptor name
      */
-    private InterceptorEnum( String name )
+    InterceptorEnum( String name )
     {
         this.name = name;
     }

Modified: directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/OperationEnum.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/OperationEnum.java?rev=1769870&r1=1769869&r2=1769870&view=diff
==============================================================================
--- directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/OperationEnum.java (original)
+++ directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/OperationEnum.java Tue Nov 15 19:28:59 2016
@@ -69,7 +69,7 @@ public enum OperationEnum
      * The private constructor
      * @param methodName The associated method name
      */
-    private OperationEnum( String methodName )
+    OperationEnum( String methodName )
     {
         this.methodName = methodName;
     }

Modified: directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/ReferralHandlingMode.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/ReferralHandlingMode.java?rev=1769870&r1=1769869&r2=1769870&view=diff
==============================================================================
--- directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/ReferralHandlingMode.java (original)
+++ directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/ReferralHandlingMode.java Tue Nov 15 19:28:59 2016
@@ -50,7 +50,7 @@ public enum ReferralHandlingMode
      * @see Context#REFERRAL
      * @param jndiValue the JNDI Context.REFERRAL key's value
      */
-    private ReferralHandlingMode( String jndiValue )
+    ReferralHandlingMode( String jndiValue )
     {
         this.jndiValue = jndiValue;
     }

Modified: directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/authn/ppolicy/CheckQualityEnum.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/authn/ppolicy/CheckQualityEnum.java?rev=1769870&r1=1769869&r2=1769870&view=diff
==============================================================================
--- directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/authn/ppolicy/CheckQualityEnum.java (original)
+++ directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/authn/ppolicy/CheckQualityEnum.java Tue Nov 15 19:28:59 2016
@@ -51,7 +51,7 @@ public enum CheckQualityEnum
     /**
      * Create a new instance of this enum
      */
-    private CheckQualityEnum( int value )
+    CheckQualityEnum( int value )
     {
         this.value = value;
     }

Modified: directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/changelog/RevisionOrder.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/changelog/RevisionOrder.java?rev=1769870&r1=1769869&r2=1769870&view=diff
==============================================================================
--- directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/changelog/RevisionOrder.java (original)
+++ directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/changelog/RevisionOrder.java Tue Nov 15 19:28:59 2016
@@ -34,7 +34,7 @@ public enum RevisionOrder
     private final boolean ascending;
 
 
-    private RevisionOrder( boolean ascending )
+    RevisionOrder( boolean ascending )
     {
         this.ascending = ascending;
     }

Modified: directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/event/EventType.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/event/EventType.java?rev=1769870&r1=1769869&r2=1769870&view=diff
==============================================================================
--- directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/event/EventType.java (original)
+++ directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/event/EventType.java Tue Nov 15 19:28:59 2016
@@ -48,7 +48,7 @@ public enum EventType
     private int mask;
 
 
-    private EventType( int mask )
+    EventType( int mask )
     {
         this.mask = mask;
     }

Modified: directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/interceptor/context/BindOperationContext.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/interceptor/context/BindOperationContext.java?rev=1769870&r1=1769869&r2=1769870&view=diff
==============================================================================
--- directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/interceptor/context/BindOperationContext.java (original)
+++ directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/interceptor/context/BindOperationContext.java Tue Nov 15 19:28:59 2016
@@ -24,6 +24,7 @@ import org.apache.commons.lang.NotImplem
 import org.apache.directory.api.ldap.model.constants.AuthenticationLevel;
 import org.apache.directory.api.ldap.model.exception.LdapAuthenticationException;
 import org.apache.directory.api.ldap.model.message.MessageTypeEnum;
+import org.apache.directory.api.ldap.model.name.Dn;
 import org.apache.directory.api.util.Strings;
 import org.apache.directory.server.core.api.CoreSession;
 import org.apache.directory.server.core.api.OperationEnum;
@@ -88,11 +89,11 @@ public class BindOperationContext extend
     public AuthenticationLevel getAuthenticationLevel() throws LdapAuthenticationException
     {
         // First check if the SASL mechanism has been set
-        if ( ( saslMechanism == null ) )
+        if ( saslMechanism == null )
         {
             // No, it's either a SIMPLE, ANONYMOUS, UNAUTHENT or an error
             //
-            if ( dn.isEmpty() )
+            if ( Dn.isNullOrEmpty( dn ) )
             {
                 if ( Strings.isEmpty( credentials ) )
                 {

Modified: directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/sp/StoredProcEngine.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/sp/StoredProcEngine.java?rev=1769870&r1=1769869&r2=1769870&view=diff
==============================================================================
--- directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/sp/StoredProcEngine.java (original)
+++ directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/api/sp/StoredProcEngine.java Tue Nov 15 19:28:59 2016
@@ -46,7 +46,7 @@ public interface StoredProcEngine
      * <p>
      * This method should be called before an attempt to invoke a stored procedure via this Engine.
      */
-    void setSPUnitEntry( final Entry spUnit );
+    void setSPUnitEntry( Entry spUnit );
 
 
     /**

Modified: directory/apacheds/trunk/core-avl/src/main/java/org/apache/directory/server/core/avltree/avl/AvlNode.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-avl/src/main/java/org/apache/directory/server/core/avltree/avl/AvlNode.java?rev=1769870&r1=1769869&r2=1769870&view=diff
==============================================================================
--- directory/apacheds/trunk/core-avl/src/main/java/org/apache/directory/server/core/avltree/avl/AvlNode.java (original)
+++ directory/apacheds/trunk/core-avl/src/main/java/org/apache/directory/server/core/avltree/avl/AvlNode.java Tue Nov 15 19:28:59 2016
@@ -37,7 +37,7 @@ final class AvlNode<T extends Comparable
     T value = null;
 
 
-    public AvlNode( AvlNode<T> parent, T value )
+    AvlNode( AvlNode<T> parent, T value )
     {
         this.parent = parent;
         this.value = value;

Modified: directory/apacheds/trunk/core-avl/src/main/java/org/apache/directory/server/core/avltree/avl/AvlTreeIterator.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-avl/src/main/java/org/apache/directory/server/core/avltree/avl/AvlTreeIterator.java?rev=1769870&r1=1769869&r2=1769870&view=diff
==============================================================================
--- directory/apacheds/trunk/core-avl/src/main/java/org/apache/directory/server/core/avltree/avl/AvlTreeIterator.java (original)
+++ directory/apacheds/trunk/core-avl/src/main/java/org/apache/directory/server/core/avltree/avl/AvlTreeIterator.java Tue Nov 15 19:28:59 2016
@@ -36,7 +36,7 @@ final class AvlTreeIterator<T extends Co
     private boolean initial = true;
 
 
-    public AvlTreeIterator( AvlNode<T> root )
+    AvlTreeIterator( AvlNode<T> root )
     {
         this.root = root;
         findNext();

Modified: directory/apacheds/trunk/core-shared/src/main/java/org/apache/directory/server/core/shared/SortedEntryComparator.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-shared/src/main/java/org/apache/directory/server/core/shared/SortedEntryComparator.java?rev=1769870&r1=1769869&r2=1769870&view=diff
==============================================================================
--- directory/apacheds/trunk/core-shared/src/main/java/org/apache/directory/server/core/shared/SortedEntryComparator.java (original)
+++ directory/apacheds/trunk/core-shared/src/main/java/org/apache/directory/server/core/shared/SortedEntryComparator.java Tue Nov 15 19:28:59 2016
@@ -65,7 +65,7 @@ class SortedEntryComparator implements C
      * @param mrOid the OID or name of the matchingrule
      * @param reverse flag to indicate the sort order
      */
-    public SortedEntryComparator( AttributeType at, String mrule, boolean reverse, SchemaManager schemaManager ) throws LdapException
+    SortedEntryComparator( AttributeType at, String mrule, boolean reverse, SchemaManager schemaManager ) throws LdapException
     {
         this.type = at;
         this.reverse = reverse;