You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Prasanna Santhanam <ts...@apache.org> on 2013/06/06 07:32:39 UTC

systemvm.iso not updated in packages

systemvm.iso doesn't update on the packages even now after following fixes.
Anyone know why this happens despite a clean build?

CLOUDSTACK-2398 is posted.

commit 55db2fe6d12338bcd5b4860aaaa52e37a9cad174
Date:   Mon Jun 3 14:05:15 2013 +0530

    mvn clean does not do a complete clean
    
    Retains the systevm.iso from the previous run causing systemvm.iso to
    never update itself. Do a complete clean install for all profiles
    specified in mvn.
    
    Signed-off-by: Prasanna Santhanam <ts...@apache.org>

commit 800cd391d5ff2baf02f7eed137f4f50edb126a4c
Author: Marcus Sorensen <ma...@betterservers.com>
Date:   Thu May 30 11:47:13 2013 -0600

    RPM build - run mvn clean before building packages, to get a build from fresh
    source
    
    Signed-off-by: Marcus Sorensen <ma...@betterservers.com> 1369936033 -0600


On Thu, May 30, 2013 at 11:44:05AM -0600, Marcus Sorensen wrote:
> Yes, I don't think it's a blocker either, now that I know what's going
> on. I'll get that added.
> 
> On Thu, May 30, 2013 at 11:21 AM, Prachi Damle <Pr...@citrix.com> wrote:
> > Marcus,
> >
> > After a clean build did your problem disappear? I don't see a reason for a NoSuchMethodError popping up, except that as you say cleaning the repository is needed.
> >
> > -Prachi
> >
> > -----Original Message-----
> > From: Chip Childers [mailto:chip.childers@sungard.com]
> > Sent: Thursday, May 30, 2013 9:48 AM
> > To: dev@cloudstack.apache.org
> > Cc: Prachi Damle
> > Subject: Re: [VOTE] Release Apache CloudStack 4.1.0 (fifth round)
> >
> > On Thu, May 30, 2013 at 10:23:31AM -0600, Marcus Sorensen wrote:
> >> I think we need to add an 'mvn clean' to the cloud.spec prior to
> >> building.  Normally, I can build RPMs, do a pull or change some code,
> >> then build RPMs, and the changes are reflected and everything is fine.
> >> However, after running 'git clean -fxd', then rebuilding the same
> >> code, reinstalling, the problem is gone. So apparently there is the
> >> possibility that some artifacts from a previous build will get into a
> >> new build, and for whatever reason this particular change in
> >> VolumeReservationVO is surfacing that.
> >
> > Yes, for debian we do mvn clean install.
> >
> > IMO this isn't a release blocker though.  Want to fix it in master and
> > 4.1 just to it's there for the next time?
> >
> >> On Thu, May 30, 2013 at 10:02 AM, Chip Childers
> >> <ch...@sungard.com> wrote:
> >> > cc'ing prachi
> >> >
> >> > On Thu, May 30, 2013 at 09:59:01AM -0600, Marcus Sorensen wrote:
> >> >> Uh, we may have a problem.  I deployed a fresh 4.1 two days ago, it
> >> >> worked, and then I deployed current 4.1 on a separate test system
> >> >> (on top of existing, but redeployed the db) and got this:
> >> >>
> >> >> 2013-05-30 09:51:30,975 ERROR [cloud.async.AsyncJobManagerImpl]
> >> >> (Job-Executor-19:job-19) Unexpected exception while executing
> >> >> org.apache.cloudstack.api.command.user.vm.DeployVMCmd
> >> >> java.lang.NoSuchMethodError:
> >> >> org.apache.cloudstack.engine.cloud.entity.api.db.VolumeReservationV
> >> >> O.<init>(JJJLjava/lang/Long;)V at
> >> >> org.apache.cloudstack.engine.cloud.entity.api.db.dao.VMReservationD
> >> >> aoImpl.saveVolumeReservation(VMReservationDaoImpl.java:99)
> >> >> at
> >> >> org.apache.cloudstack.engine.cloud.entity.api.db.dao.VMReservationD
> >> >> aoImpl.persist(VMReservationDaoImpl.java:88)
> >> >>
> >> >>
> >> >> No such method? Did I just botch the reinstall (built RPMs, force
> >> >> installed)?  I think this has something to do with the updates from
> >> >>
> >> >> CLOUDSTACK-2568
> >> >>
> >> >> So maybe Prachi can shed some light on this.  I looked through the
> >> >> mailing list and there's at least one other mention of it.
> >> >>
> >> >>
> >> >> On Thu, May 30, 2013 at 9:07 AM, David Nalley <da...@gnsa.us> wrote:
> >> >> > On Tue, May 28, 2013 at 9:47 AM, Chip Childers
> >> >> > <ch...@sungard.com> wrote:
> >> >> >> Hi All,
> >> >> >>
> >> >> >> I've created a 4.1.0 release, with the following artifacts up
> >> >> >> for a vote.
> >> >> >>
> >> >> >
> >> >> > +1
> >> >> >
> >> >> > Checked sigs and hashes
> >> >> > Built
> >> >> > Packaged RPMs for EL6.4 (using nonoss profile) Did some basic
> >> >> > testing
> >> >> >
> >> >> > --David
> >> >>
> >>

-- 
Prasanna.,

------------------------
Powered by BigRock.com


Re: systemvm.iso not updated in packages

Posted by Prasanna Santhanam <ts...@apache.org>.
On Mon, Jun 17, 2013 at 12:55:14PM -0400, Chip Childers wrote:
> On Mon, Jun 17, 2013 at 10:22:44PM +0530, Prasanna Santhanam wrote:
> > On Mon, Jun 17, 2013 at 12:08:54PM -0400, Chip Childers wrote:
> > > On Mon, Jun 17, 2013 at 11:05:43AM +0530, Prasanna Santhanam wrote:
> > > > Applied yet another fix for this from Rajesh:
> > > > 
> > > > commit 6d140538c5efc394fda8a4ddc7cb72832470d0b3
> > > > Author: Rajesh Battala <ra...@citrix.com>
> > > > Date:   Sat Jun 15 11:21:46 2013 +0530
> > > > 
> > > >     CLOUDSTACK-3004: remove duplicate ssvm-check.sh
> > > >     
> > > >     ssvm_check.sh remove the duplicate file from consoleproxy and include the
> > > >     script from secondary storage folder while packing iso
> > > >     
> > > >     Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> > > 
> > > Should this go into 4.1?
> > 
> > Yes it should, I put in 4.1.1 as a fix version for that bug - the test
> > has run but it doesn't seem to have fixed the issue in ssvm-check.sh.
> > Will take a look tomorrow after couple more runs.
> 
> OK - feel free to cherry-pick appropriate commits into the 4.1 branch as
> you see fit for this bug fix.
> 

Turns out the duplicate script doesn't exist on 4.1. but I've
cherry-picked the other two fixes related to clean packaging.

-- 
Prasanna.,

------------------------
Powered by BigRock.com


Re: systemvm.iso not updated in packages

Posted by Chip Childers <ch...@sungard.com>.
On Mon, Jun 17, 2013 at 10:22:44PM +0530, Prasanna Santhanam wrote:
> On Mon, Jun 17, 2013 at 12:08:54PM -0400, Chip Childers wrote:
> > On Mon, Jun 17, 2013 at 11:05:43AM +0530, Prasanna Santhanam wrote:
> > > Applied yet another fix for this from Rajesh:
> > > 
> > > commit 6d140538c5efc394fda8a4ddc7cb72832470d0b3
> > > Author: Rajesh Battala <ra...@citrix.com>
> > > Date:   Sat Jun 15 11:21:46 2013 +0530
> > > 
> > >     CLOUDSTACK-3004: remove duplicate ssvm-check.sh
> > >     
> > >     ssvm_check.sh remove the duplicate file from consoleproxy and include the
> > >     script from secondary storage folder while packing iso
> > >     
> > >     Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> > 
> > Should this go into 4.1?
> 
> Yes it should, I put in 4.1.1 as a fix version for that bug - the test
> has run but it doesn't seem to have fixed the issue in ssvm-check.sh.
> Will take a look tomorrow after couple more runs.

OK - feel free to cherry-pick appropriate commits into the 4.1 branch as
you see fit for this bug fix.

Thanks!

Re: systemvm.iso not updated in packages

Posted by Prasanna Santhanam <ts...@apache.org>.
On Mon, Jun 17, 2013 at 12:08:54PM -0400, Chip Childers wrote:
> On Mon, Jun 17, 2013 at 11:05:43AM +0530, Prasanna Santhanam wrote:
> > Applied yet another fix for this from Rajesh:
> > 
> > commit 6d140538c5efc394fda8a4ddc7cb72832470d0b3
> > Author: Rajesh Battala <ra...@citrix.com>
> > Date:   Sat Jun 15 11:21:46 2013 +0530
> > 
> >     CLOUDSTACK-3004: remove duplicate ssvm-check.sh
> >     
> >     ssvm_check.sh remove the duplicate file from consoleproxy and include the
> >     script from secondary storage folder while packing iso
> >     
> >     Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> 
> Should this go into 4.1?

Yes it should, I put in 4.1.1 as a fix version for that bug - the test
has run but it doesn't seem to have fixed the issue in ssvm-check.sh.
Will take a look tomorrow after couple more runs.

-- 
Prasanna.,

------------------------
Powered by BigRock.com


Re: systemvm.iso not updated in packages

Posted by Chip Childers <ch...@sungard.com>.
On Mon, Jun 17, 2013 at 11:05:43AM +0530, Prasanna Santhanam wrote:
> Applied yet another fix for this from Rajesh:
> 
> commit 6d140538c5efc394fda8a4ddc7cb72832470d0b3
> Author: Rajesh Battala <ra...@citrix.com>
> Date:   Sat Jun 15 11:21:46 2013 +0530
> 
>     CLOUDSTACK-3004: remove duplicate ssvm-check.sh
>     
>     ssvm_check.sh remove the duplicate file from consoleproxy and include the
>     script from secondary storage folder while packing iso
>     
>     Signed-off-by: Prasanna Santhanam <ts...@apache.org>

Should this go into 4.1?


Re: systemvm.iso not updated in packages

Posted by Prasanna Santhanam <ts...@apache.org>.
Applied yet another fix for this from Rajesh:

commit 6d140538c5efc394fda8a4ddc7cb72832470d0b3
Author: Rajesh Battala <ra...@citrix.com>
Date:   Sat Jun 15 11:21:46 2013 +0530

    CLOUDSTACK-3004: remove duplicate ssvm-check.sh
    
    ssvm_check.sh remove the duplicate file from consoleproxy and include the
    script from secondary storage folder while packing iso
    
    Signed-off-by: Prasanna Santhanam <ts...@apache.org>

On Thu, Jun 06, 2013 at 11:02:39AM +0530, Prasanna Santhanam wrote:
> systemvm.iso doesn't update on the packages even now after following fixes.
> Anyone know why this happens despite a clean build?
> 
> CLOUDSTACK-2398 is posted.
> 
> commit 55db2fe6d12338bcd5b4860aaaa52e37a9cad174
> Date:   Mon Jun 3 14:05:15 2013 +0530
> 
>     mvn clean does not do a complete clean
>     
>     Retains the systevm.iso from the previous run causing systemvm.iso to
>     never update itself. Do a complete clean install for all profiles
>     specified in mvn.
>     
>     Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> 
> commit 800cd391d5ff2baf02f7eed137f4f50edb126a4c
> Author: Marcus Sorensen <ma...@betterservers.com>
> Date:   Thu May 30 11:47:13 2013 -0600
> 
>     RPM build - run mvn clean before building packages, to get a build from fresh
>     source
>     
>     Signed-off-by: Marcus Sorensen <ma...@betterservers.com> 1369936033 -0600
> 
> 
> On Thu, May 30, 2013 at 11:44:05AM -0600, Marcus Sorensen wrote:
> > Yes, I don't think it's a blocker either, now that I know what's going
> > on. I'll get that added.
> > 
> > On Thu, May 30, 2013 at 11:21 AM, Prachi Damle <Pr...@citrix.com> wrote:
> > > Marcus,
> > >
> > > After a clean build did your problem disappear? I don't see a reason for a NoSuchMethodError popping up, except that as you say cleaning the repository is needed.
> > >
> > > -Prachi
> > >
> > > -----Original Message-----
> > > From: Chip Childers [mailto:chip.childers@sungard.com]
> > > Sent: Thursday, May 30, 2013 9:48 AM
> > > To: dev@cloudstack.apache.org
> > > Cc: Prachi Damle
> > > Subject: Re: [VOTE] Release Apache CloudStack 4.1.0 (fifth round)
> > >
> > > On Thu, May 30, 2013 at 10:23:31AM -0600, Marcus Sorensen wrote:
> > >> I think we need to add an 'mvn clean' to the cloud.spec prior to
> > >> building.  Normally, I can build RPMs, do a pull or change some code,
> > >> then build RPMs, and the changes are reflected and everything is fine.
> > >> However, after running 'git clean -fxd', then rebuilding the same
> > >> code, reinstalling, the problem is gone. So apparently there is the
> > >> possibility that some artifacts from a previous build will get into a
> > >> new build, and for whatever reason this particular change in
> > >> VolumeReservationVO is surfacing that.
> > >
> > > Yes, for debian we do mvn clean install.
> > >
> > > IMO this isn't a release blocker though.  Want to fix it in master and
> > > 4.1 just to it's there for the next time?
> > >
> > >> On Thu, May 30, 2013 at 10:02 AM, Chip Childers
> > >> <ch...@sungard.com> wrote:
> > >> > cc'ing prachi
> > >> >
> > >> > On Thu, May 30, 2013 at 09:59:01AM -0600, Marcus Sorensen wrote:
> > >> >> Uh, we may have a problem.  I deployed a fresh 4.1 two days ago, it
> > >> >> worked, and then I deployed current 4.1 on a separate test system
> > >> >> (on top of existing, but redeployed the db) and got this:
> > >> >>
> > >> >> 2013-05-30 09:51:30,975 ERROR [cloud.async.AsyncJobManagerImpl]
> > >> >> (Job-Executor-19:job-19) Unexpected exception while executing
> > >> >> org.apache.cloudstack.api.command.user.vm.DeployVMCmd
> > >> >> java.lang.NoSuchMethodError:
> > >> >> org.apache.cloudstack.engine.cloud.entity.api.db.VolumeReservationV
> > >> >> O.<init>(JJJLjava/lang/Long;)V at
> > >> >> org.apache.cloudstack.engine.cloud.entity.api.db.dao.VMReservationD
> > >> >> aoImpl.saveVolumeReservation(VMReservationDaoImpl.java:99)
> > >> >> at
> > >> >> org.apache.cloudstack.engine.cloud.entity.api.db.dao.VMReservationD
> > >> >> aoImpl.persist(VMReservationDaoImpl.java:88)
> > >> >>
> > >> >>
> > >> >> No such method? Did I just botch the reinstall (built RPMs, force
> > >> >> installed)?  I think this has something to do with the updates from
> > >> >>
> > >> >> CLOUDSTACK-2568
> > >> >>
> > >> >> So maybe Prachi can shed some light on this.  I looked through the
> > >> >> mailing list and there's at least one other mention of it.
> > >> >>
> > >> >>
> > >> >> On Thu, May 30, 2013 at 9:07 AM, David Nalley <da...@gnsa.us> wrote:
> > >> >> > On Tue, May 28, 2013 at 9:47 AM, Chip Childers
> > >> >> > <ch...@sungard.com> wrote:
> > >> >> >> Hi All,
> > >> >> >>
> > >> >> >> I've created a 4.1.0 release, with the following artifacts up
> > >> >> >> for a vote.
> > >> >> >>
> > >> >> >
> > >> >> > +1
> > >> >> >
> > >> >> > Checked sigs and hashes
> > >> >> > Built
> > >> >> > Packaged RPMs for EL6.4 (using nonoss profile) Did some basic
> > >> >> > testing
> > >> >> >
> > >> >> > --David
> > >> >>
> > >>
> 
> -- 
> Prasanna.,
> 
> ------------------------
> Powered by BigRock.com

-- 
Prasanna.,

------------------------
Powered by BigRock.com