You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Michael Brohl <mi...@ecomify.de> on 2017/10/30 10:18:48 UTC
Re: svn commit: r1813627 -
/ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
Hi Arun,
thanks for your work. You could help us save some time by sticking to
the commit message template.
Please see my previous message to Rishi.
In this case, the correct message would be formatted:
===
Fixed: Issue while creating new person in the party component.
(OFBIZ-9653)
Thanks Rubia Elza Joshep and Suraj Khurana for your contribution.
===
Thank you and best regards,
Michael
Am 28.10.17 um 15:16 schrieb arunpatidar@apache.org:
> Author: arunpatidar
> Date: Sat Oct 28 13:16:01 2017
> New Revision: 1813627
>
> URL: http://svn.apache.org/viewvc?rev=1813627&view=rev
> Log:
> FIXED:Issue while creating new person in the party component. (OFBIZ-9653)
> Thanks Rubia Elza Joshep and Suraj Khurana for your contribution.
>
> Modified:
> ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
>
> Modified: ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml?rev=1813627&r1=1813626&r2=1813627&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml (original)
> +++ ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml Sat Oct 28 13:16:01 2017
> @@ -368,7 +368,9 @@ under the License.
> <request-map uri="createPerson">
> <security https="true" auth="true"/>
> <event type="service" path="" invoke="createPerson"/>
> - <response name="success" type="request-redirect" value="viewprofile"/>
> + <response name="success" type="request-redirect" value="viewprofile">
> + <redirect-parameter name="partyId"/>
> + </response>
> <response name="error" type="view" value="EditPerson"/>
> </request-map>
> <request-map uri="updatePerson">
>
>
Re: svn commit: r1813627 - /ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
Posted by Arun Patidar <ar...@hotwaxsystems.com>.
Thanks Michael for your notes. I have updated log message in rev:1813627 as
per best practice.
--
Thanks & Regards
---
Arun Patidar
Manager, Enterprise Software Development
HotWax Systems Pvt Ltd.
www.hotwaxsystems.com
On Mon, Oct 30, 2017 at 3:48 PM, Michael Brohl <mi...@ecomify.de>
wrote:
> Hi Arun,
>
> thanks for your work. You could help us save some time by sticking to the
> commit message template.
>
> Please see my previous message to Rishi.
>
> In this case, the correct message would be formatted:
>
> ===
>
> Fixed: Issue while creating new person in the party component.
> (OFBIZ-9653)
>
> Thanks Rubia Elza Joshep and Suraj Khurana for your contribution.
>
> ===
>
> Thank you and best regards,
>
> Michael
>
> Am 28.10.17 um 15:16 schrieb arunpatidar@apache.org:
>
> Author: arunpatidar
>> Date: Sat Oct 28 13:16:01 2017
>> New Revision: 1813627
>>
>> URL: http://svn.apache.org/viewvc?rev=1813627&view=rev
>> Log:
>> FIXED:Issue while creating new person in the party component. (OFBIZ-9653)
>> Thanks Rubia Elza Joshep and Suraj Khurana for your contribution.
>>
>> Modified:
>> ofbiz/ofbiz-framework/trunk/applications/party/webapp/party
>> mgr/WEB-INF/controller.xml
>>
>> Modified: ofbiz/ofbiz-framework/trunk/applications/party/webapp/partym
>> gr/WEB-INF/controller.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/app
>> lications/party/webapp/partymgr/WEB-INF/controller.xml?rev=
>> 1813627&r1=1813626&r2=1813627&view=diff
>> ============================================================
>> ==================
>> --- ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
>> (original)
>> +++ ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
>> Sat Oct 28 13:16:01 2017
>> @@ -368,7 +368,9 @@ under the License.
>> <request-map uri="createPerson">
>> <security https="true" auth="true"/>
>> <event type="service" path="" invoke="createPerson"/>
>> - <response name="success" type="request-redirect"
>> value="viewprofile"/>
>> + <response name="success" type="request-redirect"
>> value="viewprofile">
>> + <redirect-parameter name="partyId"/>
>> + </response>
>> <response name="error" type="view" value="EditPerson"/>
>> </request-map>
>> <request-map uri="updatePerson">
>>
>>
>>
>
>