You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/29 07:41:44 UTC

[GitHub] [pulsar] nlu90 opened a new pull request #7844: [Issue 7742][functions] Allow kubernetes runtime to customize function instance class path

nlu90 opened a new pull request #7844:
URL: https://github.com/apache/pulsar/pull/7844


   Fixes #1338
   
   
   ### Motivation
   
   
   Currently, the function worker is using the function worker's classpath to configure the function instance (runner)'s classpath. So when the broker (function worker) is using an image that is different from the function instance (runner) for kubernetes runtime, the classpath will be wrong and the function instance is not able to load the instance classes.
   
   
   ### Modifications
   
   Adding an function instance class path entry into the kubernetes runtime config. And construct the function launch command accordingly.
   
   
   ### Verifying this change
   
   - [X] Make sure that the change passes the CI checks.
   
   
   This change is already covered by existing tests, such as KubernetesRuntimeTest.
   
   
   ### Does this pull request potentially affect one of the following parts:
   
     No
   
   ### Documentation
   
     - Does this pull request introduce a new feature? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui closed pull request #7844: [Issue 7742][functions] Allow kubernetes runtime to customize function instance class path

Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #7844:
URL: https://github.com/apache/pulsar/pull/7844


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #7844: [Issue 7742][functions] Allow kubernetes runtime to customize function instance class path

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7844:
URL: https://github.com/apache/pulsar/pull/7844#issuecomment-718451254


   need to cherry-pick to 2.6.2.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy merged pull request #7844: [Issue 7742][functions] Allow kubernetes runtime to customize function instance class path

Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #7844:
URL: https://github.com/apache/pulsar/pull/7844


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #7844: [Issue 7742][functions] Allow kubernetes runtime to customize function instance class path

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7844:
URL: https://github.com/apache/pulsar/pull/7844#issuecomment-679394955


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #7844: [Issue 7742][functions] Allow kubernetes runtime to customize function instance class path

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7844:
URL: https://github.com/apache/pulsar/pull/7844#issuecomment-718393414


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #7844: [Issue 7742][functions] Allow kubernetes runtime to customize function instance class path

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7844:
URL: https://github.com/apache/pulsar/pull/7844#issuecomment-718354806


   @nlu90 please help to process this pull request.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org