You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/02/14 09:46:45 UTC

[GitHub] cbickel commented on a change in pull request #4289: Make ContainerProxyTests more stable.

cbickel commented on a change in pull request #4289: Make ContainerProxyTests more stable.
URL: https://github.com/apache/incubator-openwhisk/pull/4289#discussion_r256757666
 
 

 ##########
 File path: tests/src/test/scala/org/apache/openwhisk/core/containerpool/test/ContainerProxyTests.scala
 ##########
 @@ -304,12 +307,15 @@ class ContainerProxyTests
       container.suspendCount shouldBe 0
       acker.calls should have size 2
 
-      // Add debugging information for the case of failure.
-      println(acker.calls.map(_._2.toJson.compactPrint))
-
       store.calls should have size 2
 
-      val initRunActivation = acker.calls(0)._2
+      // As the active acks are sent asynchronously, it is possible, that the activation with the init time is not the
+      // first one in the buffer.
+      val initializedActivations =
+        acker.calls.filter(_._2.annotations.get(WhiskActivation.initTimeAnnotation).isDefined)
+      initializedActivations should have size 1
+
+      val initRunActivation = initializedActivations.head._2
 
 Review comment:
   That's a good point. 👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services