You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/09/07 06:50:10 UTC
[GitHub] [iceberg] zhong-yj opened a new pull request #3081: Fix ClassCastException when flink read map and array data from parquet format data file.
zhong-yj opened a new pull request #3081:
URL: https://github.com/apache/iceberg/pull/3081
This pr is related to #3080, it adds a buildGenericMapData() in FlinkParquetReaders$ReusableMapData and adds a buildGenericArrayData() in FlinkParquetReaders$ReusableArrayData, and the XXReaders build the GenericXXData for return, which solves the ClassCastException when reading MapData and ArrayData from parquet data file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] zlzhang0122 commented on pull request #3081: Fix ClassCastException when flink read map and array data from parquet format data file.
Posted by GitBox <gi...@apache.org>.
zlzhang0122 commented on pull request #3081:
URL: https://github.com/apache/iceberg/pull/3081#issuecomment-914186171
LGTM！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] zhong-yj commented on pull request #3081: Fix ClassCastException when flink read map and array data from parquet format data file.
Posted by GitBox <gi...@apache.org>.
zhong-yj commented on pull request #3081:
URL: https://github.com/apache/iceberg/pull/3081#issuecomment-914046315
@openinx @chenjunjiedada, could you help to review this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx commented on a change in pull request #3081: Fix ClassCastException when flink read map and array data from parquet format data file.
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #3081:
URL: https://github.com/apache/iceberg/pull/3081#discussion_r703457744
##########
File path: flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java
##########
@@ -24,16 +24,11 @@
import java.nio.ByteBuffer;
import java.time.Instant;
import java.time.ZoneOffset;
+import java.util.Arrays;
import java.util.List;
import java.util.Map;
-import org.apache.flink.table.data.ArrayData;
-import org.apache.flink.table.data.DecimalData;
-import org.apache.flink.table.data.GenericRowData;
-import org.apache.flink.table.data.MapData;
-import org.apache.flink.table.data.RawValueData;
-import org.apache.flink.table.data.RowData;
-import org.apache.flink.table.data.StringData;
-import org.apache.flink.table.data.TimestampData;
+
+import org.apache.flink.table.data.*;
Review comment:
In iceberg, we usually don't use `*` to import package, it's more clear to import the specify package one by one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx commented on pull request #3081: Fix ClassCastException when flink read map and array data from parquet format data file.
Posted by GitBox <gi...@apache.org>.
openinx commented on pull request #3081:
URL: https://github.com/apache/iceberg/pull/3081#issuecomment-927454345
This bug has been addressed since we've successfully integrated to flink 1.13.2 in here : https://github.com/apache/iceberg/pull/3116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx closed pull request #3081: Fix ClassCastException when flink read map and array data from parquet format data file.
Posted by GitBox <gi...@apache.org>.
openinx closed pull request #3081:
URL: https://github.com/apache/iceberg/pull/3081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] coolderli commented on pull request #3081: Fix ClassCastException when flink read map and array data from parquet format data file.
Posted by GitBox <gi...@apache.org>.
coolderli commented on pull request #3081:
URL: https://github.com/apache/iceberg/pull/3081#issuecomment-914174350
Make sense to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx commented on pull request #3081: Fix ClassCastException when flink read map and array data from parquet format data file.
Posted by GitBox <gi...@apache.org>.
openinx commented on pull request #3081:
URL: https://github.com/apache/iceberg/pull/3081#issuecomment-914905167
I tried this by building flink-iceberg-runtime.jar and running the SQL in flink 1.13.2 local cluster. All things works as expected
 .
Let's just close this PR , and turn to upgrade the flink version to 1.13.2 #2629 . Close this now. Thanks @zhong-yj for your reporting and contribution !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org