You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "lintingbin (via GitHub)" <gi...@apache.org> on 2025/06/03 07:50:30 UTC

[PR] Modify the default value of hive catalog clients to 20 [amoro]

lintingbin opened a new pull request, #3590:
URL: https://github.com/apache/amoro/pull/3590

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
     2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
   -->
   
   ## Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about its use case.
     2. If you fix a bug, you can clarify why it is a bug.
     3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
   -->
   
   Close #3587.
   
   ## Brief change log
   <!--
   Clearly describe the changes made in modules, classes, methods, etc.
   -->
   
   - Fixed the default value of clients to 20 and set the clients parameter when creating an external Hive metastore catalog.
   - Added description of the clients parameter in the docs/admin-guides/managing-catalogs.md document
   
   ## How was this patch tested?
   
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [x] Run test locally before making a pull request
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AMORO-3587] Modify the default value of hive catalog clients to 20 [amoro]

Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on code in PR #3590:
URL: https://github.com/apache/amoro/pull/3590#discussion_r2179305101


##########
amoro-ams/src/main/java/org/apache/amoro/server/catalog/CatalogBuilder.java:
##########
@@ -88,6 +90,9 @@ public static ServerCatalog buildServerCatalog(
       case CATALOG_TYPE_HIVE:
         String amsUri = getAmsURI(serverConfiguration);
         catalogMeta.getCatalogProperties().put(CatalogMetaProperties.AMS_URI, amsUri);
+        catalogMeta

Review Comment:
   why do we need to add this logic here, seems that we'll set the properties when constructing catalogmetadata?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AMORO-3587] Modify the default value of hive catalog clients to 20 [amoro]

Posted by "lintingbin (via GitHub)" <gi...@apache.org>.
lintingbin commented on code in PR #3590:
URL: https://github.com/apache/amoro/pull/3590#discussion_r2181948379


##########
amoro-ams/src/main/java/org/apache/amoro/server/catalog/CatalogBuilder.java:
##########
@@ -88,6 +90,9 @@ public static ServerCatalog buildServerCatalog(
       case CATALOG_TYPE_HIVE:
         String amsUri = getAmsURI(serverConfiguration);
         catalogMeta.getCatalogProperties().put(CatalogMetaProperties.AMS_URI, amsUri);
+        catalogMeta

Review Comment:
   Here you can add to make the default value of 20 take effect, and it will also display the current value on the front-end web page, allowing users to modify it as needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AMORO-3587] Modify the default value of hive catalog clients to 20 [amoro]

Posted by "czy006 (via GitHub)" <gi...@apache.org>.
czy006 merged PR #3590:
URL: https://github.com/apache/amoro/pull/3590


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org