You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/10/28 09:33:42 UTC

[GitHub] [incubator-dolphinscheduler] IamMujuziMoses commented on a change in pull request #3949: Feature ui 3941

IamMujuziMoses commented on a change in pull request #3949:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3949#discussion_r513297983



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TenantController.java
##########
@@ -90,12 +88,11 @@
     @ApiException(CREATE_TENANT_ERROR)
     public Result createTenant(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
                                @RequestParam(value = "tenantCode") String tenantCode,
-                               @RequestParam(value = "tenantName") String tenantName,
                                @RequestParam(value = "queueId") int queueId,
                                @RequestParam(value = "description", required = false) String description) throws Exception {
-        logger.info("login user {}, create tenant, tenantCode: {}, tenantName: {}, queueId: {}, desc: {}",
-                loginUser.getUserName(), tenantCode, tenantName, queueId, description);
-        Map<String, Object> result = tenantService.createTenant(loginUser, tenantCode, tenantName, queueId, description);
+        logger.info("login user {}, create tenant, tenantCode: {}, queueId: {}, desc: {}",
+                loginUser.getUserName(), tenantCode, queueId, description);

Review comment:
       SonarCloud is still producing errors




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org