You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/27 18:26:56 UTC
[GitHub] [beam] riteshghorse opened a new pull request, #22476: [Go SDK]: Plumb allowed lateness to execution
riteshghorse opened a new pull request, #22476:
URL: https://github.com/apache/beam/pull/22476
Right now we are always setting the Allowed Lateness to 0 irrespective of what the user sets it. This PR fixes it by assigning it from the windowing strategy.
Fix #22474
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #22476: [Go SDK]: Plumb allowed lateness to execution
Posted by GitBox <gi...@apache.org>.
riteshghorse commented on PR #22476:
URL: https://github.com/apache/beam/pull/22476#issuecomment-1197331179
Since @lostluck is out today, can anyone do a quick review for making it to 2.41?
R: @jrmccluskey @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #22476: [Go SDK]: Plumb allowed lateness to execution
Posted by GitBox <gi...@apache.org>.
lostluck commented on code in PR #22476:
URL: https://github.com/apache/beam/pull/22476#discussion_r931584373
##########
sdks/go/pkg/beam/core/runtime/graphx/translate.go:
##########
@@ -834,7 +834,7 @@ func (m *marshaller) expandReshuffle(edge NamedEdge) (string, error) {
MergeStatus: pipepb.MergeStatus_NON_MERGING,
WindowCoderId: windowCoderId,
ClosingBehavior: pipepb.ClosingBehavior_EMIT_IF_NONEMPTY,
- AllowedLateness: 0,
+ AllowedLateness: int64(in.From.WindowingStrategy().AllowedLateness),
Review Comment:
This line needs to be reverted, but it may not need to be?
I'd prefer to keep it explicit since we are basically serializing the old windowing strategy + event times, and writing to a shuffle with a new on in the Global Window. Nothing can be late in the Global Window, but we shouldn't be diverging our definition from Python and Java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #22476: [Go SDK]: Plumb allowed lateness to execution
Posted by GitBox <gi...@apache.org>.
riteshghorse commented on PR #22476:
URL: https://github.com/apache/beam/pull/22476#issuecomment-1197191918
Run Go PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22476: [Go SDK]: Plumb allowed lateness to execution
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22476:
URL: https://github.com/apache/beam/pull/22476#issuecomment-1197361606
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on a diff in pull request #22476: [Go SDK]: Plumb allowed lateness to execution
Posted by GitBox <gi...@apache.org>.
riteshghorse commented on code in PR #22476:
URL: https://github.com/apache/beam/pull/22476#discussion_r931624777
##########
sdks/go/pkg/beam/core/runtime/graphx/translate.go:
##########
@@ -834,7 +834,7 @@ func (m *marshaller) expandReshuffle(edge NamedEdge) (string, error) {
MergeStatus: pipepb.MergeStatus_NON_MERGING,
WindowCoderId: windowCoderId,
ClosingBehavior: pipepb.ClosingBehavior_EMIT_IF_NONEMPTY,
- AllowedLateness: 0,
+ AllowedLateness: int64(in.From.WindowingStrategy().AllowedLateness),
Review Comment:
I also wasn't sure about it but Java implementation seems to be preserving the allowed lateness value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey merged pull request #22476: [Go SDK]: Plumb allowed lateness to execution
Posted by GitBox <gi...@apache.org>.
jrmccluskey merged PR #22476:
URL: https://github.com/apache/beam/pull/22476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #22476: [Go SDK]: Plumb allowed lateness to execution
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22476:
URL: https://github.com/apache/beam/pull/22476#issuecomment-1197280481
# [Codecov](https://codecov.io/gh/apache/beam/pull/22476?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22476](https://codecov.io/gh/apache/beam/pull/22476?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f6855d) into [master](https://codecov.io/gh/apache/beam/commit/0760f13c4a5ca1dcfa0e2fad7d875e2d2f050963?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0760f13) will **not change** coverage.
> The diff coverage is `100.00%`.
> :exclamation: Current head 9f6855d differs from pull request most recent head 5ebd842. Consider uploading reports for the commit 5ebd842 to get more accurate results
```diff
@@ Coverage Diff @@
## master #22476 +/- ##
=======================================
Coverage 74.17% 74.17%
=======================================
Files 706 706
Lines 93226 93226
=======================================
Hits 69154 69154
Misses 22804 22804
Partials 1268 1268
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `51.49% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/22476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/core/runtime/graphx/translate.go](https://codecov.io/gh/apache/beam/pull/22476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZ3JhcGh4L3RyYW5zbGF0ZS5nbw==) | `42.45% <100.00%> (ø)` | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #22476: [Go SDK]: Plumb allowed lateness to execution
Posted by GitBox <gi...@apache.org>.
riteshghorse commented on PR #22476:
URL: https://github.com/apache/beam/pull/22476#issuecomment-1197228160
Run Go PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22476: [Go SDK]: Plumb allowed lateness to execution
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22476:
URL: https://github.com/apache/beam/pull/22476#issuecomment-1197327053
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @lostluck for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org