You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Randgalt <gi...@git.apache.org> on 2014/07/22 23:16:35 UTC
[GitHub] curator pull request: Curator 123
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/20
Curator 123
ConnectedReadOnly should be considered a "negative" state and not cause the CONNECTED state to get posted.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/20.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20
----
commit feb13e1c16de7078dfc1310d9403441d1b2dae9e
Author: randgalt <ra...@apache.org>
Date: 2014-07-22T21:05:19Z
Test case that shows the problem
commit a86a667bb1213fec26fbdb8354bdc01b9fe70396
Author: randgalt <ra...@apache.org>
Date: 2014-07-22T21:07:13Z
Fix that causes CONNECT to be sent when the read/write connection is established. It can be argued that CONNECT should never be sent though. Discussing...
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: Curator 123
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/curator/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: Curator 123
Posted by cammckenzie <gi...@git.apache.org>.
Github user cammckenzie commented on the pull request:
https://github.com/apache/curator/pull/20#issuecomment-49808183
Couple of minor comments about System.out.println() in the test case. Other than that, looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---